Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2306483002: Converted Observatory code-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Converted Observatory code-view element Not fully testable R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/741d99f10095439b18741fd1a1b3bffa51435fc3

Patch Set 1 #

Patch Set 2 : Removed dead code #

Total comments: 4

Patch Set 3 : Added missing ref #

Patch Set 4 : Fixed tables headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -310 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 7 chunks +6 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_view.dart View 1 2 3 15 chunks +312 lines, -97 lines 0 comments Download
D runtime/observatory/lib/src/elements/code_view.html View 1 chunk +0 lines, -154 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 2 chunks +68 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/any_ref.dart View 1 2 2 chunks +40 lines, -36 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + runtime/observatory/lib/src/elements/type_arguments_ref.dart View 1 2 2 chunks +16 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/code.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/code.dart View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
cbernaschina
4 years, 3 months ago (2016-09-01 02:04:52 UTC) #2
cbernaschina
4 years, 3 months ago (2016-09-01 16:09:44 UTC) #3
cbernaschina
It was a missing ref for the type TypeArguments
4 years, 3 months ago (2016-09-01 18:24:18 UTC) #4
rmacnak
lgtm https://chromiumcodereview.appspot.com/2306483002/diff/20001/runtime/observatory/lib/src/elements/code_view.dart File runtime/observatory/lib/src/elements/code_view.dart (right): https://chromiumcodereview.appspot.com/2306483002/diff/20001/runtime/observatory/lib/src/elements/code_view.dart#newcode158 runtime/observatory/lib/src/elements/code_view.dart:158: document.createElement('th')..classes = ['address'] The headers for the two ...
4 years, 3 months ago (2016-09-01 19:38:09 UTC) #5
cbernaschina
https://codereview.chromium.org/2306483002/diff/20001/runtime/observatory/lib/src/elements/code_view.dart File runtime/observatory/lib/src/elements/code_view.dart (right): https://codereview.chromium.org/2306483002/diff/20001/runtime/observatory/lib/src/elements/code_view.dart#newcode158 runtime/observatory/lib/src/elements/code_view.dart:158: document.createElement('th')..classes = ['address'] On 2016/09/01 19:38:09, rmacnak wrote: > ...
4 years, 3 months ago (2016-09-01 20:56:34 UTC) #6
cbernaschina
4 years, 3 months ago (2016-09-01 20:56:53 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
741d99f10095439b18741fd1a1b3bffa51435fc3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698