Issue 23050014: Convert drive::FileWriteHelper to a single function for simplification.

Issue 23050014: Convert drive::FileWriteHelper to a single function for simplification. (Closed)

Created:
7 years, 4 months ago by kinaba

Modified:
7 years, 4 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert drive::FileWriteHelper to a single function for simplification. BUG=276071 TEST=Manually tested screenshot taking and downloading. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218601

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -297 lines)			Patch
M	chrome/browser/chromeos/drive/download_handler.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/download_handler.cc	View	3 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/drive/download_handler_unittest.cc	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_integration_service.cc	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util.h	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system_util.cc	View	3 chunks	+10 lines, -16 lines	0 comments	Download
D	chrome/browser/chromeos/drive/file_write_helper.h	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	chrome/browser/chromeos/drive/file_write_helper.cc	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	chrome/browser/chromeos/drive/file_write_helper_unittest.cc	View	1 chunk	+0 lines, -103 lines	0 comments	Download
A	chrome/browser/chromeos/drive/write_on_cache_file.h	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/drive/write_on_cache_file.cc	View	1 chunk	+58 lines, -0 lines	0 comments	Download
A +	chrome/browser/chromeos/drive/write_on_cache_file_unittest.cc	View	3 chunks	+13 lines, -18 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/23050014/1

7 years, 4 months ago (2013-08-20 08:24:25 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-20 08:35:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/23050014/1

7 years, 4 months ago (2013-08-21 01:47:56 UTC) #5

Message was sent while issue was closed.

Change committed as 218601

Expand Messages | Collapse Messages