Remove autocheckout code.

Remove autocheckout code.

BUG=276002
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220695

[Raman Kakilate, 2013-08-20 17:44:45]

PTAL.

[aruslan, 2013-08-20 17:53:31]

On 2013/08/20 17:44:45, Raman Kakilate wrote:
> PTAL.

Thanks, please remove those from Android as well:
chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h
chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

[Raman Kakilate, 2013-08-20 18:02:44]

On 2013/08/20 17:53:31, aruslan wrote:
> On 2013/08/20 17:44:45, Raman Kakilate wrote:
> > PTAL.
> 
> Thanks, please remove those from Android as well:
> chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h
> chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc

Done.

[Dan Beam, 2013-08-20 21:44:08]

lgtm but i don't own all of components/autofill/core so i didn't look all that
hard there

https://codereview.chromium.org/23033016/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/23033016/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1152: bool
AutofillDialogControllerImpl::ShouldShowDetailArea() const {
^ maybe delete this?

https://codereview.chromium.org/23033016/diff/1/components/autofill/core/brow...
File components/autofill/core/browser/autofill_manager_delegate.h (right):

https://codereview.chromium.org/23033016/diff/1/components/autofill/core/brow...
components/autofill/core/browser/autofill_manager_delegate.h:38: //
TODO(ramankk): Simplify dialog type when removing autocheckout.
where is this still used?

https://codereview.chromium.org/23033016/diff/1/components/autofill/core/brow...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/23033016/diff/1/components/autofill/core/brow...
components/autofill/core/browser/autofill_metrics_unittest.cc:157: :
FormStructure(form) {}
nit: if this is legal in chrome code/style:

  explicit TestFormStructure(const FormData& form) : FormStructure(form) {}

[benquan, 2013-08-20 22:00:47]

You may also need to delete Autocheckout related messages from
chromium/src/chrome/app/generated_resources.grd

[Dan Beam, 2013-08-20 22:05:45]

On 2013/08/20 22:00:47, benquan wrote:
> You may also need to delete Autocheckout related messages from
> chromium/src/chrome/app/generated_resources.grd

as well as histograms.xml

git grep -i autocheckout # is your friend

[Raman Kakilate, 2013-08-22 21:29:04]

https://codereview.chromium.org/23033016/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/23033016/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1152: bool
AutofillDialogControllerImpl::ShouldShowDetailArea() const {
On 2013/08/20 21:44:08, Dan Beam wrote:
> ^ maybe delete this?

Probably - but may be in next CL.

https://codereview.chromium.org/23033016/diff/1/components/autofill/core/brow...
File components/autofill/core/browser/autofill_manager_delegate.h (right):

https://codereview.chromium.org/23033016/diff/1/components/autofill/core/brow...
components/autofill/core/browser/autofill_manager_delegate.h:38: //
TODO(ramankk): Simplify dialog type when removing autocheckout.
On 2013/08/20 21:44:08, Dan Beam wrote:
> where is this still used?

Should probably be deleted in separate CL.

~/chrome2/src$ git grep -i DialogType | grep autofill | wc -l
125

[Evan Stade, 2013-08-26 18:23:26]

lgtm, but it would be nice for Ilya to take a look as well.

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller.h (left):

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller.h:71: virtual DialogType
GetDialogType() const = 0;
can you remove this or flag it for removal?

[Ilya Sherman, 2013-08-27 18:57:57]

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1154: }
Could you remove this method, or mark it as slated for removal?

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:3248: }
Can this method now be removed?

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc (right):

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc:167: 
nit: Spurious blank line.

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/tab_autofill_manager_delegate.h (right):

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/tab_autofill_manager_delegate.h:12: #include
"chrome/browser/ui/autofill/autofill_dialog_types.h"
nit: Is this still needed?

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
components/autofill/core/browser/autofill_metrics_unittest.cc:157: :
FormStructure(form) {}
nit: Looks like this ought to now fit on the previous line.

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
File components/autofill/core/browser/autofill_xml_parser.cc (left):

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
components/autofill/core/browser/autofill_xml_parser.cc:156: is_in_type_section_
= true;
Just to make sure: Are you also planning to send out a corresponding change to
remove these code paths from the server?

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
File components/autofill/core/browser/form_structure.cc (right):

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
components/autofill/core/browser/form_structure.cc:668: }
nit: Seems reasonable to inline this method at this point.

https://codereview.chromium.org/23033016/diff/22001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/23033016/diff/22001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:878: -</histogram>
Please mark the histograms as <obsolete> rather than deleting them.

[Ilya Sherman, 2013-08-27 19:04:41]

Also, your change currently conflicts with
https://chromiumcodereview.appspot.com/22926033/ -- just mentioning in case that
change lands first, so that you don't accidentally revert it while rebasing.

[Raman Kakilate, 2013-08-27 21:52:58]

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller.h (left):

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller.h:71: virtual DialogType
GetDialogType() const = 0;
On 2013/08/26 18:23:26, Evan Stade wrote:
> can you remove this or flag it for removal?

Done.

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1154: }
On 2013/08/27 18:57:57, Ilya Sherman wrote:
> Could you remove this method, or mark it as slated for removal?

Done.

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:3248: }
On 2013/08/27 18:57:57, Ilya Sherman wrote:
> Can this method now be removed?

Done.

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc (right):

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc:167: 
On 2013/08/27 18:57:57, Ilya Sherman wrote:
> nit: Spurious blank line.

Done.

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/tab_autofill_manager_delegate.h (right):

https://codereview.chromium.org/23033016/diff/22001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/tab_autofill_manager_delegate.h:12: #include
"chrome/browser/ui/autofill/autofill_dialog_types.h"
On 2013/08/27 18:57:57, Ilya Sherman wrote:
> nit: Is this still needed?

Done.

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
components/autofill/core/browser/autofill_metrics_unittest.cc:157: :
FormStructure(form) {}
On 2013/08/27 18:57:57, Ilya Sherman wrote:
> nit: Looks like this ought to now fit on the previous line.

Done.

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
File components/autofill/core/browser/autofill_xml_parser.cc (left):

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
components/autofill/core/browser/autofill_xml_parser.cc:156: is_in_type_section_
= true;
On 2013/08/27 18:57:57, Ilya Sherman wrote:
> Just to make sure: Are you also planning to send out a corresponding change to
> remove these code paths from the server?

Its already submitted.

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
File components/autofill/core/browser/form_structure.cc (right):

https://codereview.chromium.org/23033016/diff/22001/components/autofill/core/...
components/autofill/core/browser/form_structure.cc:668: }
On 2013/08/27 18:57:57, Ilya Sherman wrote:
> nit: Seems reasonable to inline this method at this point.

Done.

https://codereview.chromium.org/23033016/diff/22001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/23033016/diff/22001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:878: -</histogram>
On 2013/08/27 18:57:57, Ilya Sherman wrote:
> Please mark the histograms as <obsolete> rather than deleting them.

Done.

[Raman Kakilate, 2013-08-27 21:53:54]

On 2013/08/27 19:04:41, Ilya Sherman wrote:
> Also, your change currently conflicts with
> https://chromiumcodereview.appspot.com/22926033/ -- just mentioning in case
that
> change lands first, so that you don't accidentally revert it while rebasing.

Thanks for the headsup.

[Ilya Sherman, 2013-08-27 22:44:46]

LGTM, thanks.

[commit-bot: I haz the power, 2013-08-27 23:41:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/23033016/39001

[commit-bot: I haz the power, 2013-08-28 00:47:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/23033016/39001

[commit-bot: I haz the power, 2013-08-28 03:28:41]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Raman Kakilate, 2013-08-28 16:20:30]

+aruslan for chrome/browser/ui/android/autofill/*
+sail for chrome/browser/profiles/
+mkoshiba for android_webview
+cdn for autofill messages

Thanks,

[Cris Neckar, 2013-08-28 16:57:20]

On 2013/08/28 16:20:30, Raman Kakilate wrote:
> +aruslan for chrome/browser/ui/android/autofill/*
> +sail for chrome/browser/profiles/
> +mkoshiba for android_webview
> +cdn for autofill messages
> 
> Thanks,

IPC messages rubber stamp lgtm

[aruslan, 2013-08-28 17:00:42]

android/ lgtm.

https://codereview.chromium.org/23033016/diff/39001/chrome/browser/ui/android...
File chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h
(right):

https://codereview.chromium.org/23033016/diff/39001/chrome/browser/ui/android...
chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h:96:
const DialogType dialog_type_;
I think you would want to remove the dialog type as well.

[Raman Kakilate, 2013-08-28 17:12:23]

https://codereview.chromium.org/23033016/diff/39001/chrome/browser/ui/android...
File chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h
(right):

https://codereview.chromium.org/23033016/diff/39001/chrome/browser/ui/android...
chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h:96:
const DialogType dialog_type_;
On 2013/08/28 17:00:43, aruslan wrote:
> I think you would want to remove the dialog type as well.

Differing removing of DialogType to next CL, I have a TODO in this CL.

[sail, 2013-08-28 17:29:27]

profiles/* lgtm

[mkosiba (inactive), 2013-08-29 09:28:28]

android_webview/ LGTM

[commit-bot: I haz the power, 2013-08-29 16:11:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/23033016/39001

[commit-bot: I haz the power, 2013-08-29 19:43:29]

Retried try job too often on win_rel for step(s) browser_tests,
chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests,
content_browsertests, mini_installer_test, nacl_integration,
sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-08-30 19:52:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/23033016/39001

[commit-bot: I haz the power, 2013-08-30 23:36:31]

Change committed as 220695