Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: components/autofill/core/browser/autofill_metrics.cc

Issue 23033016: Remove autocheckout code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Even more deletes, and Ilya review. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.cc
diff --git a/components/autofill/core/browser/autofill_metrics.cc b/components/autofill/core/browser/autofill_metrics.cc
index 57743c3b7fd0070de6b00e926851ed6fc822d39a..11c37130b30b8ac1b60033756680fa86ba5d1efd 100644
--- a/components/autofill/core/browser/autofill_metrics.cc
+++ b/components/autofill/core/browser/autofill_metrics.cc
@@ -184,8 +184,6 @@ std::string WalletApiMetricToString(
return "GetWalletItems";
case AutofillMetrics::SAVE_TO_WALLET:
return "SaveToWallet";
- case AutofillMetrics::SEND_STATUS:
- return "SendStatus";
case AutofillMetrics::UNKNOWN_API_CALL:
NOTREACHED();
return "UnknownApiCall";
@@ -276,7 +274,7 @@ void LogServerExperimentId(const std::string& histogram_name,
ServerExperiment metric = UNKNOWN_EXPERIMENT;
const std::string default_experiment_name =
- FormStructure(FormData(), std::string()).server_experiment_id();
+ FormStructure(FormData()).server_experiment_id();
if (experiment_id.empty())
metric = NO_EXPERIMENT;
else if (experiment_id == "ar06")
@@ -324,20 +322,6 @@ AutofillMetrics::AutofillMetrics() {
AutofillMetrics::~AutofillMetrics() {
}
-void AutofillMetrics::LogAutocheckoutBubbleMetric(BubbleMetric metric) const {
- DCHECK_LT(metric, NUM_BUBBLE_METRICS);
-
- UMA_HISTOGRAM_ENUMERATION("Autocheckout.Bubble", metric, NUM_BUBBLE_METRICS);
-}
-
-void AutofillMetrics::LogAutocheckoutBuyFlowMetric(
- AutocheckoutBuyFlowMetric metric) const {
- DCHECK_LT(metric, NUM_AUTOCHECKOUT_BUY_FLOW_METRICS);
-
- UMA_HISTOGRAM_ENUMERATION("Autocheckout.BuyFlow", metric,
- NUM_AUTOCHECKOUT_BUY_FLOW_METRICS);
-}
-
void AutofillMetrics::LogCreditCardInfoBarMetric(InfoBarMetric metric) const {
DCHECK_LT(metric, NUM_INFO_BAR_METRICS);
@@ -430,47 +414,6 @@ void AutofillMetrics::LogWalletRequiredActionMetric(
name, required_action, NUM_WALLET_REQUIRED_ACTIONS);
}
-void AutofillMetrics::LogAutocheckoutDuration(
- const base::TimeDelta& duration,
- AutocheckoutCompletionStatus status) const {
- std::string suffix;
- switch (status) {
- case AUTOCHECKOUT_CANCELLED:
- suffix = "Cancelled";
- break;
-
- case AUTOCHECKOUT_FAILED:
- suffix = "Failed";
- break;
-
- case AUTOCHECKOUT_SUCCEEDED:
- suffix = "Succeeded";
- break;
- }
-
- LogUMAHistogramLongTimes("Autocheckout.FlowDuration", duration);
- LogUMAHistogramLongTimes("Autocheckout.FlowDuration." + suffix, duration);
-}
-
-void AutofillMetrics::LogAutocheckoutWhitelistDownloadDuration(
- const base::TimeDelta& duration,
- AutocheckoutWhitelistDownloadStatus status) const {
- std::string suffix;
- switch (status) {
- case AUTOCHECKOUT_WHITELIST_DOWNLOAD_FAILED:
- suffix = "Failed";
- break;
-
- case AUTOCHECKOUT_WHITELIST_DOWNLOAD_SUCCEEDED:
- suffix = "Succeeded";
- break;
- }
-
- LogUMAHistogramTimes("Autocheckout.WhitelistDownloadDuration", duration);
- LogUMAHistogramTimes(
- "Autocheckout.WhitelistDownloadDuration." + suffix, duration);
-}
-
void AutofillMetrics::LogDeveloperEngagementMetric(
DeveloperEngagementMetric metric) const {
DCHECK_LT(metric, NUM_DEVELOPER_ENGAGEMENT_METRICS);

Powered by Google App Engine
This is Rietveld 408576698