Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2303173002: Converted Observatory metrics-page element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Converted Observatory metrics-page element Major restyle R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/cfefe9749586a698665950d20107e55385c86634

Patch Set 1 #

Patch Set 2 : Added sampling buffer size select #

Total comments: 8

Patch Set 3 : Removed unnecessary trailing semicolons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+715 lines, -476 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +9 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 3 chunks +21 lines, -47 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 chunk +32 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/metric/details.dart View 1 1 chunk +148 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/metric/graph.dart View 1 chunk +119 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/metrics.dart View 1 chunk +147 lines, -208 lines 0 comments Download
D runtime/observatory/lib/src/elements/metrics.html View 1 chunk +0 lines, -147 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/metric.dart View 1 chunk +7 lines, -5 lines 0 comments Download
A runtime/observatory/lib/src/models/repositories/metric.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/metric.dart View 1 2 1 chunk +192 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 chunks +1 line, -66 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 4 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 3 months ago (2016-09-02 02:39:02 UTC) #2
cbernaschina
4 years, 3 months ago (2016-09-02 16:40:32 UTC) #3
rmacnak
lgtm https://chromiumcodereview.appspot.com/2303173002/diff/20001/runtime/observatory/lib/src/repositories/metric.dart File runtime/observatory/lib/src/repositories/metric.dart (right): https://chromiumcodereview.appspot.com/2303173002/diff/20001/runtime/observatory/lib/src/repositories/metric.dart#newcode88 runtime/observatory/lib/src/repositories/metric.dart:88: }; switch doesn't need trailing https://chromiumcodereview.appspot.com/2303173002/diff/20001/runtime/observatory/lib/src/repositories/metric.dart#newcode113 runtime/observatory/lib/src/repositories/metric.dart:113: }; ...
4 years, 3 months ago (2016-09-06 16:46:04 UTC) #4
cbernaschina
https://codereview.chromium.org/2303173002/diff/20001/runtime/observatory/lib/src/repositories/metric.dart File runtime/observatory/lib/src/repositories/metric.dart (right): https://codereview.chromium.org/2303173002/diff/20001/runtime/observatory/lib/src/repositories/metric.dart#newcode88 runtime/observatory/lib/src/repositories/metric.dart:88: }; On 2016/09/06 16:46:04, rmacnak wrote: > switch doesn't ...
4 years, 3 months ago (2016-09-06 16:51:40 UTC) #5
cbernaschina
4 years, 3 months ago (2016-09-06 16:56:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
cfefe9749586a698665950d20107e55385c86634 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698