Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: content/renderer/render_view_impl.cc

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | extensions/browser/extension_error.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 4d450a257ee7376ec8637868fca02047de23225a..3002d78840af4ef82aebfdfcdb4829203b526a85 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2414,12 +2414,22 @@ void RenderViewImpl::didAddMessageToConsole(
NOTREACHED();
}
+ if (shouldReportDetailedMessageForSource(source_name)) {
+ FOR_EACH_OBSERVER(
+ RenderViewObserver,
+ observers_,
+ DetailedConsoleMessageAdded(message.text,
+ source_name,
+ stack_trace,
+ source_line,
+ static_cast<int32>(log_severity)));
+ }
+
Send(new ViewHostMsg_AddMessageToConsole(routing_id_,
static_cast<int32>(log_severity),
message.text,
static_cast<int32>(source_line),
- source_name,
- stack_trace));
+ source_name));
}
void RenderViewImpl::printPage(WebFrame* frame) {
« no previous file with comments | « content/public/renderer/render_view_observer.h ('k') | extensions/browser/extension_error.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698