Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: content/public/renderer/render_view_observer.h

Issue 23007021: Report Javascript Runtime Errors to the Error Console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ec_feldman
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/render_view_observer.h
diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h
index 10dad336607c8e4d37da75a257a1a93a4c3a8f63..164c3703e1facf0ff7f7e1249c455333e9de06e1 100644
--- a/content/public/renderer/render_view_observer.h
+++ b/content/public/renderer/render_view_observer.h
@@ -91,6 +91,18 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,
virtual void DidHandleGestureEvent(const WebKit::WebGestureEvent& event) {}
virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {}
+ // Called when we receive a console message from WebKit for which we requested
+ // extra details (like the stack trace). |message| is the error message,
+ // |source| is the WebKit-reported source of the error (either external or
+ // internal), and |stack_trace| is the stack trace of the error in a
+ // human-readable format (each frame is formatted as
+ // "\n at function_name (source:line_number:column_number)").
+ virtual void DetailedConsoleMessageAdded(const base::string16& message,
+ const base::string16& source,
+ const base::string16& stack_trace,
+ int32 line_number,
+ int32 severity_level) {}
+
// These match incoming IPCs.
virtual void Navigate(const GURL& url) {}
virtual void ClosePage() {}
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698