WebCrypto: assert that WebArrayBuffers are not null.

WebCrypto: assert that WebArrayBuffers are not null.

This is a defensive check in case the platform layer passes in a bogus WebArrayBuffer. It is possible to create a null WebArrayBuffer by making its byte size exceed 2^32. For instance "WebArrayBuffer::create(0xFFFFFFFF, 8)"

BUG=245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156578

[abarth-chromium, 2013-08-22 18:44:09]

> WebArrayBuffer::create(0xFFFFFFFF, 8)

That doesn't just crash?

[abarth-chromium, 2013-08-22 18:44:13]

lgtm

[commit-bot: I haz the power, 2013-08-22 18:57:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/23003021/3001

[commit-bot: I haz the power, 2013-08-22 21:06:34]

Change committed as 156578

[eroman, 2013-08-22 21:33:13]

WebArrayBuffer::create() can fail creation and return NULL data, meaning
consumers need to test it before using it.

The only case I could find where this happens is when the requested data is
larger than 2^23 (possible because the size is specified as number of
elements rather than number of bytes).

Source:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

I decided to add some defensive checks to avoid operating on the NULL
buffer later.
Conceptually I see it as an error on the part of the caller.



On Thu, Aug 22, 2013 at 11:44 AM, <abarth@chromium.org> wrote:

> WebArrayBuffer::create(**0xFFFFFFFF, 8)
>>
>
> That doesn't just crash?
>
>
https://codereview.chromium.**org/23003021/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.