Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22981005: [telemetry] Move Results options out of PageTest/Measurement into their own module. (Closed)

Created:
7 years, 4 months ago by dtu
Modified:
7 years, 4 months ago
Reviewers:
tonyg, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, Sami, vclarke1
Visibility:
Public.

Description

[telemetry] Move Results options out of PageTest/Measurement into their own module. They were troublesome in PageTest/Measurement because usually you don't know what the PageTest/Measurement will be until after you parse the options. BUG=255696, 270884 TEST=tools/perf/run_benchmark run --help; tools/perf/run_measurement --help; content/test/gpu/run_gpu_test webgl_conformance Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217984

Patch Set 1 : puppy #

Total comments: 2

Patch Set 2 : Including skyostil's patch, 22866004 #

Patch Set 3 : Remove output_file from browser_options #

Patch Set 4 : Merge. #

Patch Set 5 : Fix unit test. #

Patch Set 6 : Re-add output_file to appease the unittest gods #

Patch Set 7 : Merge and lint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -119 lines) Patch
M tools/telemetry/telemetry/core/browser_options.py View 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/csv_page_measurement_results.py View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/gtest_test_results.py View 2 chunks +26 lines, -21 lines 0 comments Download
M tools/telemetry/telemetry/page/page_measurement.py View 2 chunks +3 lines, -58 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 2 3 4 5 6 3 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 2 3 4 5 6 4 chunks +4 lines, -28 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_runner.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
A tools/telemetry/telemetry/page/results_options.py View 1 chunk +84 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/gtest_testrunner.py View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
dtu
7 years, 4 months ago (2013-08-15 00:13:31 UTC) #1
nduca
nice lgtm
7 years, 4 months ago (2013-08-15 01:15:30 UTC) #2
tonyg
lgtm Such a great cleanup, thanks! https://codereview.chromium.org/22981005/diff/3001/tools/telemetry/telemetry/core/browser_options.py File tools/telemetry/telemetry/core/browser_options.py (right): https://codereview.chromium.org/22981005/diff/3001/tools/telemetry/telemetry/core/browser_options.py#newcode56 tools/telemetry/telemetry/core/browser_options.py:56: self.output_file = None ...
7 years, 4 months ago (2013-08-15 15:53:47 UTC) #3
dtu
https://codereview.chromium.org/22981005/diff/3001/tools/telemetry/telemetry/core/browser_options.py File tools/telemetry/telemetry/core/browser_options.py (right): https://codereview.chromium.org/22981005/diff/3001/tools/telemetry/telemetry/core/browser_options.py#newcode56 tools/telemetry/telemetry/core/browser_options.py:56: self.output_file = None On 2013/08/15 15:53:48, tonyg wrote: > ...
7 years, 4 months ago (2013-08-15 20:39:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/22981005/5003
7 years, 4 months ago (2013-08-15 22:21:48 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160567
7 years, 4 months ago (2013-08-15 23:21:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/22981005/30002
7 years, 4 months ago (2013-08-16 00:06:53 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160608
7 years, 4 months ago (2013-08-16 01:04:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/22981005/62001
7 years, 4 months ago (2013-08-16 01:13:38 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160647
7 years, 4 months ago (2013-08-16 02:23:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/22981005/70001
7 years, 4 months ago (2013-08-16 07:52:37 UTC) #11
commit-bot: I haz the power
7 years, 4 months ago (2013-08-16 09:51:42 UTC) #12
Message was sent while issue was closed. 
Change committed as 217984

Powered by Google App Engine
This is Rietveld 408576698