Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 22981005: [telemetry] Move Results options out of PageTest/Measurement into their own module. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge and lint. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 1fdda4d35090b82de54954dd0f1e0053944765b1..4687e42e6abebc08fa88f2d4ff6a04b57f2b7f5d 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -20,6 +20,7 @@ from telemetry.page import page_filter as page_filter_module
from telemetry.page import page_measurement_results
from telemetry.page import page_runner_repeat
from telemetry.page import page_test
+from telemetry.page import results_options
from telemetry.page.actions import navigate
@@ -146,6 +147,7 @@ class PageState(object):
def AddCommandLineOptions(parser):
page_filter_module.PageFilter.AddCommandLineOptions(parser)
+ results_options.AddResultsOptions(parser)
def _LogStackTrace(title, browser):
@@ -214,7 +216,7 @@ def _PrepareAndRunPage(test, page_set, expectations, options, page,
def Run(test, page_set, expectations, options):
"""Runs a given test against a given page_set with the given options."""
- results = test.PrepareResults(options)
+ results = results_options.PrepareResults(test, options)
# Create a possible_browser with the given options.
test.CustomizeBrowserOptions(options)
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698