Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 22967006: Adding polyfill support for custom elements. (Closed)

Created:
7 years, 4 months ago by blois
Modified:
7 years, 4 months ago
Reviewers:
sra1, Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding polyfill support for custom elements. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26405

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Removing mutation observer polyfill from test. #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1598 lines, -17 lines) Patch
A pkg/custom_element/lib/custom-elements.debug.js View 1 chunk +1458 lines, -0 lines 0 comments Download
A pkg/custom_element/lib/custom-elements.min.js View 1 chunk +28 lines, -0 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +32 lines, -9 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +16 lines, -1 line 0 comments Download
M tests/html/custom_elements_test.dart View 1 4 chunks +16 lines, -2 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/dart2js_CustomElementSupport.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/src/dart2js_Platform.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M tools/dom/src/dartium_Platform.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 4 months ago (2013-08-20 18:27:40 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/22967006/diff/6006/tests/html/custom_elements_test.dart File tests/html/custom_elements_test.dart (right): https://codereview.chromium.org/22967006/diff/6006/tests/html/custom_elements_test.dart#newcode58 tests/html/custom_elements_test.dart:58: useHtmlIndividualConfiguration(); does this need to be individual config? it ...
7 years, 4 months ago (2013-08-20 19:09:59 UTC) #2
blois
https://codereview.chromium.org/22967006/diff/11001/pkg/custom_element/lib/custom-elements.debug.js File pkg/custom_element/lib/custom-elements.debug.js (right): https://codereview.chromium.org/22967006/diff/11001/pkg/custom_element/lib/custom-elements.debug.js#newcode1 pkg/custom_element/lib/custom-elements.debug.js:1: // Copyright (c) 2012 The Polymer Authors. All rights ...
7 years, 4 months ago (2013-08-20 19:36:55 UTC) #3
Jennifer Messerly
thanks Pete, it all makes sense. LGTM
7 years, 4 months ago (2013-08-20 21:58:43 UTC) #4
blois
7 years, 4 months ago (2013-08-20 22:56:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r26405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698