Issue 22966004: Revert "Replace style sharing cousin list search with LRU"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22966004: Revert "Replace style sharing cousin list search with LRU" (Closed)

Created:
7 years, 4 months ago by leviw_travelin_and_unemployed

Modified:
7 years, 4 months ago

Reviewers:
esprehn

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Replace style sharing cousin list search with LRU" This reverts commit r156070 because of a performance regression. BUG=273605 TBR=esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156247

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -77 lines)			Patch
M	Source/core/css/resolver/SharedStyleFinder.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/SharedStyleFinder.cpp	View	5 chunks	+78 lines, -42 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View	4 chunks	+0 lines, -11 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/22966004/1

7 years, 4 months ago (2013-08-16 16:51:04 UTC) #1

commit-bot: I haz the power

Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=2444

7 years, 4 months ago (2013-08-16 20:21:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/22966004/1

7 years, 4 months ago (2013-08-16 20:47:18 UTC) #3

Message was sent while issue was closed.

Change committed as 156247

Expand Messages | Collapse Messages