Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 22962005: Merge pull request #581 from kevmoo/polymer (Closed)

Created:
7 years, 4 months ago by terry
Modified:
7 years, 4 months ago
Reviewers:
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/web-ui.git@polymer
Visibility:
Public.

Description

Merge pull request #581 from kevmoo/polymer Locking down, cleaning up... dwc: locking down members that likely should not be accessible from other libs tiny tweaks remove bad pub dependency Several cleanups in polymer lib and compiler - remove ScopedCss class (not needed after we removed the css mangling). - remove 'Hashable' - delete code that was moved to the 'codegen' and 'observe' packages, and switch to those packages instead. [boot.js] fix the order problem (issue #578) Merge pull request #574 from kevmoo/polymer removed a pile of unused imports removed a pile of unused imports fix event.dart remove unused files Remove abstract on PolymerElement. This also fixes https://code.google.com/p/dart/issues/detail?id=12254 A few extra fixes needed before publishing. ShadowDOMPolyfill tests still fail, but everything else is looking better. update pubspec cleanup comments fixes for latest SDK Refactoring our compiler: moving the css emitting code around a bit, remove css-mangling option. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1135 lines, -6120 lines) Patch
M build.dart View 1 chunk +1 line, -3 lines 0 comments Download
M example/component/news/test/expected/news_index_test.html.txt View 2 chunks +37 lines, -25 lines 0 comments Download
M example/todomvc/test/expected/todomvc_listorder_test.html.txt View 8 chunks +178 lines, -116 lines 0 comments Download
M example/todomvc/test/expected/todomvc_mainpage2_test.html.txt View 6 chunks +88 lines, -62 lines 0 comments Download
M example/todomvc/test/expected/todomvc_mainpage_test.html.txt View 5 chunks +45 lines, -37 lines 0 comments Download
M example/todomvc/test/expected/todomvc_markdone_test.html.txt View 9 chunks +222 lines, -142 lines 0 comments Download
M example/todomvc/test/test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M example/todomvc/test/todomvc_listorder_test.html View 1 chunk +17 lines, -28 lines 0 comments Download
M example/todomvc/test/todomvc_mainpage2_test.html View 1 chunk +3 lines, -11 lines 0 comments Download
M example/todomvc/test/todomvc_mainpage_test.html View 1 chunk +0 lines, -2 lines 0 comments Download
M example/todomvc/test/todomvc_markdone_test.html View 2 chunks +17 lines, -28 lines 0 comments Download
M example/todomvc/web/app.html View 1 chunk +3 lines, -3 lines 0 comments Download
M example/todomvc/web/editable_label.dart View 2 chunks +6 lines, -22 lines 0 comments Download
M example/todomvc/web/editable_label.html View 1 chunk +3 lines, -4 lines 0 comments Download
M example/todomvc/web/model.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M example/todomvc/web/todo_row.html View 1 chunk +1 line, -1 line 0 comments Download
M lib/boot.js View 3 chunks +11 lines, -12 lines 0 comments Download
M lib/dwc.dart View 5 chunks +11 lines, -11 lines 0 comments Download
D lib/event.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M lib/observe.dart View 3 chunks +6 lines, -8 lines 0 comments Download
M lib/observe_html.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/polymer.dart View 2 chunks +16 lines, -14 lines 0 comments Download
M lib/polymer_element.dart View 6 chunks +36 lines, -29 lines 0 comments Download
M lib/safe_html.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D lib/scoped_css.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D lib/shadowdom.debug.js View 1 chunk +0 lines, -3221 lines 0 comments Download
D lib/shadowdom.min.js View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/analyzer.dart View 8 chunks +10 lines, -176 lines 0 comments Download
D lib/src/code_printer.dart View 1 chunk +0 lines, -245 lines 0 comments Download
M lib/src/compiler.dart View 14 chunks +41 lines, -41 lines 0 comments Download
M lib/src/compiler_options.dart View 5 chunks +5 lines, -20 lines 0 comments Download
A + lib/src/css_analyzer.dart View 12 chunks +134 lines, -217 lines 0 comments Download
A lib/src/css_emitters.dart View 1 chunk +155 lines, -0 lines 0 comments Download
M lib/src/dart_parser.dart View 4 chunks +8 lines, -41 lines 0 comments Download
M lib/src/emitters.dart View 8 chunks +43 lines, -314 lines 0 comments Download
M lib/src/files.dart View 1 chunk +0 lines, -1 line 0 comments Download
D lib/src/html_css_fixup.dart View 1 chunk +0 lines, -590 lines 0 comments Download
M lib/src/info.dart View 3 chunks +1 line, -7 lines 0 comments Download
M lib/src/messages.dart View 5 chunks +5 lines, -4 lines 0 comments Download
D lib/src/observable_transform.dart View 1 chunk +0 lines, -325 lines 0 comments Download
D lib/src/refactor.dart View 1 chunk +0 lines, -136 lines 0 comments Download
M lib/src/utils.dart View 2 chunks +0 lines, -17 lines 0 comments Download
M lib/testing/content_shell_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pubspec.yaml View 2 chunks +7 lines, -5 lines 0 comments Download
M test/css_test.dart View 7 chunks +13 lines, -8 lines 0 comments Download
D test/observable_transform_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D test/refactor_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
M test/run_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M test/testing.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698