Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: lib/observe.dart

Issue 22962005: Merge pull request #581 from kevmoo/polymer (Closed) Base URL: https://github.com/dart-lang/web-ui.git@polymer
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/event.dart ('k') | lib/observe_html.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/observe.dart
diff --git a/lib/observe.dart b/lib/observe.dart
index 7f7e2a73cf7f7f8e8aa1733e7c067061729cdd1d..0a02a9071e38049e3329f58ed15936134194cea9 100644
--- a/lib/observe.dart
+++ b/lib/observe.dart
@@ -4,19 +4,13 @@
/**
* Helpers for observable objects.
- * Intended for use with `package:mdv_observe`.
+ * Intended for use with `package:observe`.
*/
library polymer.observe;
import 'dart:async';
-// TODO(jmesserly): PathObserver should be in mdv_observe.
-import 'dart:html' show PathObserver;
import 'package:observe/observe.dart';
-// Inspired by ArrayReduction at:
-// https://raw.github.com/rafaelw/ChangeSummary/master/util/array_reduction.js
-// The main difference is we support anything on the rich Dart Iterable API.
-
const _VALUE = const Symbol('value');
/**
@@ -59,6 +53,10 @@ void notifyProperty(Observable target, Symbol targetName) {
}
+// Inspired by ArrayReduction at:
+// https://raw.github.com/rafaelw/ChangeSummary/master/util/array_reduction.js
+// The main difference is we support anything on the rich Dart Iterable API.
+
/**
* Observes a path starting from each item in the list.
*/
@@ -107,7 +105,7 @@ class ListPathObserver<E, P> extends ChangeNotifierBase {
runAsync(_reduce);
}
- _observeItems(int lengthAdjust) {
+ void _observeItems(int lengthAdjust) {
if (lengthAdjust > 0) {
for (int i = 0; i < lengthAdjust; i++) {
int len = _observers.length;
« no previous file with comments | « lib/event.dart ('k') | lib/observe_html.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698