Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2296083003: Refactoring: Remove CSSImageValue::m_isCachePending (Closed)

Created:
4 years, 3 months ago by hajimehoshi
Modified:
4 years, 3 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: Remove CSSImageValue::m_isCachePending CSSImageValue::m_isCachePending is true iff CSSImageValue::m_cachedImage is null. This CL removes this redundant member for code health. BUG=n/a TEST=n/a Committed: https://crrev.com/06959eda1ef116ad723b9396f2cf6e7506a63729 Cr-Commit-Position: refs/heads/master@{#415581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/core/css/CSSImageValue.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageValue.cpp View 5 chunks +2 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
hajimehoshi
PTAL
4 years, 3 months ago (2016-08-31 06:12:03 UTC) #2
kouhei (in TOK)
lgtm % test pass
4 years, 3 months ago (2016-08-31 06:24:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296083003/1
4 years, 3 months ago (2016-08-31 07:50:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 08:06:33 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 08:08:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06959eda1ef116ad723b9396f2cf6e7506a63729
Cr-Commit-Position: refs/heads/master@{#415581}

Powered by Google App Engine
This is Rietveld 408576698