Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSImageValue.h

Issue 2296083003: Refactoring: Remove CSSImageValue::m_isCachePending (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSImageValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2008, 2012 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 static CSSImageValue* create(const AtomicString& rawValue, const KURL& url, StyleImage* image = 0) 47 static CSSImageValue* create(const AtomicString& rawValue, const KURL& url, StyleImage* image = 0)
48 { 48 {
49 return new CSSImageValue(rawValue, url, image); 49 return new CSSImageValue(rawValue, url, image);
50 } 50 }
51 static CSSImageValue* create(const AtomicString& absoluteURL) 51 static CSSImageValue* create(const AtomicString& absoluteURL)
52 { 52 {
53 return new CSSImageValue(absoluteURL); 53 return new CSSImageValue(absoluteURL);
54 } 54 }
55 ~CSSImageValue(); 55 ~CSSImageValue();
56 56
57 bool isCachePending() const { return m_isCachePending; } 57 bool isCachePending() const { return !m_cachedImage; }
58 StyleImage* cachedImage() const { ASSERT(!isCachePending()); return m_cached Image.get(); } 58 StyleImage* cachedImage() const { ASSERT(!isCachePending()); return m_cached Image.get(); }
59 StyleImage* cacheImage(Document*, CrossOriginAttributeValue = CrossOriginAtt ributeNotSet); 59 StyleImage* cacheImage(Document*, CrossOriginAttributeValue = CrossOriginAtt ributeNotSet);
60 60
61 const String& url() const { return m_absoluteURL; } 61 const String& url() const { return m_absoluteURL; }
62 62
63 void setReferrer(const Referrer& referrer) { m_referrer = referrer; } 63 void setReferrer(const Referrer& referrer) { m_referrer = referrer; }
64 const Referrer& referrer() const { return m_referrer; } 64 const Referrer& referrer() const { return m_referrer; }
65 65
66 void reResolveURL(const Document&) const; 66 void reResolveURL(const Document&) const;
67 67
(...skipping 18 matching lines...) Expand all
86 private: 86 private:
87 CSSImageValue(const AtomicString& rawValue, const KURL&, StyleImage*); 87 CSSImageValue(const AtomicString& rawValue, const KURL&, StyleImage*);
88 CSSImageValue(const AtomicString& absoluteURL); 88 CSSImageValue(const AtomicString& absoluteURL);
89 89
90 AtomicString m_relativeURL; 90 AtomicString m_relativeURL;
91 Referrer m_referrer; 91 Referrer m_referrer;
92 AtomicString m_initiatorName; 92 AtomicString m_initiatorName;
93 93
94 // Cached image data. 94 // Cached image data.
95 mutable AtomicString m_absoluteURL; 95 mutable AtomicString m_absoluteURL;
96 mutable bool m_isCachePending;
97 mutable Member<StyleImage> m_cachedImage; 96 mutable Member<StyleImage> m_cachedImage;
98 }; 97 };
99 98
100 DEFINE_CSS_VALUE_TYPE_CASTS(CSSImageValue, isImageValue()); 99 DEFINE_CSS_VALUE_TYPE_CASTS(CSSImageValue, isImageValue());
101 100
102 } // namespace blink 101 } // namespace blink
103 102
104 #endif // CSSImageValue_h 103 #endif // CSSImageValue_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSImageValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698