App install alerts: Disable on all channels for M35

chrome/browser/android/banners/app_banner_manager.cc

Index: chrome/browser/android/banners/app_banner_manager.cc
diff --git a/chrome/browser/android/banners/app_banner_manager.cc b/chrome/browser/android/banners/app_banner_manager.cc
index 03488077bca50f5e88188bf33eaa512080d2e597..b260f6ad1c199a044d4d050861b8ad35e220d26d 100644
--- a/chrome/browser/android/banners/app_banner_manager.cc
+++ b/chrome/browser/android/banners/app_banner_manager.cc
@@ -7,6 +7,7 @@
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/command_line.h"
+#include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/android/banners/app_banner_metrics_ids.h"
 #include "chrome/browser/android/banners/app_banner_settings_helper.h"
@@ -25,7 +26,12 @@ using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertUTF8ToJavaString;
 
 namespace {

[Nico, 2014/04/08 22:55:24]

(const has implicit internal linkage, this unnamed namespace has no effect)

[gone, 2014/04/08 23:22:21]

Done.

+// The meta tag that developers add to their web pages to trigger banners.
 const char kBannerTag[] = "google-play-id";
+
+// Finch trial experiment for enabling app banners.
+const char kBannerFieldTrial[] = "AppInstallAlerts";
+const char kBannerFieldTrialEnabled[] = "AppInstallAlertsEnabled";
 }
 
 namespace banners {
@@ -152,8 +158,15 @@ jlong Init(JNIEnv* env, jobject obj) {
 }
 
 jboolean IsEnabled(JNIEnv* env, jclass clazz) {
-  return !CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kDisableAppBanners);
+  // Check if the Finch trial is enabled for this client.
+  std::string group_name =
+      base::FieldTrialList::FindFullName(kBannerFieldTrial);
+  if (kBannerFieldTrialEnabled == group_name)
+    return true;
+
+  // Check if there is a command line flag enabling this feature.
+  return CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kEnableAppInstallAlerts);
 }
 
 // Register native methods