App install alerts: Disable on all channels for M35

chrome/browser/android/banners/app_banner_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_manager.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/command_line.h"
+#include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/android/banners/app_banner_metrics_ids.h"
 #include "chrome/browser/android/banners/app_banner_settings_helper.h"
 #include "chrome/browser/android/banners/app_banner_utilities.h"
 #include "chrome/browser/bitmap_fetcher.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "jni/AppBannerManager_jni.h"
 #include "ui/gfx/android/java_bitmap.h"
 
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertUTF8ToJavaString;
 
 namespace {

[Nico, 2014/04/08 22:55:24]

(const has implicit internal linkage, this unnamed namespace has no effect)

[gone, 2014/04/08 23:22:21]

Done.

+// The meta tag that developers add to their web pages to trigger banners.
 const char kBannerTag[] = "google-play-id";
+
+// Finch trial experiment for enabling app banners.
+const char kBannerFieldTrial[] = "AppInstallAlerts";
+const char kBannerFieldTrialEnabled[] = "AppInstallAlertsEnabled";
 }
 
 namespace banners {
 
 AppBannerManager::AppBannerManager(JNIEnv* env, jobject obj)
     : MetaTagObserver(kBannerTag),
       weak_java_banner_view_manager_(env, obj) {}
 
 AppBannerManager::~AppBannerManager() {
 }
@@ skipping 106 matching lines @@
 void RecordInstallEvent(JNIEnv* env, jclass clazz, jint metric) {
   banners::TrackInstallEvent(metric);
 }
 
 jlong Init(JNIEnv* env, jobject obj) {
   AppBannerManager* manager = new AppBannerManager(env, obj);
   return reinterpret_cast<intptr_t>(manager);
 }
 
 jboolean IsEnabled(JNIEnv* env, jclass clazz) {
-  return !CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kDisableAppBanners);
+  // Check if the Finch trial is enabled for this client.
+  std::string group_name =
+      base::FieldTrialList::FindFullName(kBannerFieldTrial);
+  if (kBannerFieldTrialEnabled == group_name)
+    return true;
+
+  // Check if there is a command line flag enabling this feature.
+  return CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kEnableAppInstallAlerts);
 }
 
 // Register native methods
 bool RegisterAppBannerManager(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace banners