Issue 22933005: [android] Make build_type a singleton.

Issue 22933005: [android] Make build_type a singleton. (Closed)

Created:
7 years, 4 months ago by craigdh

Modified:
7 years, 4 months ago

Reviewers:
bulach, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[android] Make build_type a singleton. BUG=260494 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217855

Patch Set 2 : fix call to _LogToFile #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -74 lines)			Patch
M	build/android/pylib/base/base_test_runner.py	View		4 chunks	+3 lines, -7 lines	0 comments	Download
M	build/android/pylib/base/test_dispatcher.py	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	build/android/pylib/chrome_test_server_spawner.py	View		6 chunks	+6 lines, -8 lines	0 comments	Download
M	build/android/pylib/constants.py	View		1 chunk	+11 lines, -0 lines	1 comment	Download
M	build/android/pylib/device_stats_monitor.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	build/android/pylib/fake_dns.py	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	build/android/pylib/gtest/setup.py	View		3 chunks	+8 lines, -9 lines	0 comments	Download
M	build/android/pylib/gtest/test_options.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/gtest/test_package_apk.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	build/android/pylib/gtest/test_package_exe.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	build/android/pylib/gtest/test_runner.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/host_driven/setup.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/host_driven/test_case.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	build/android/pylib/host_driven/test_runner.py	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	build/android/pylib/instrumentation/test_options.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/monkey/test_options.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/monkey/test_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/uiautomator/test_options.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/uiautomator/test_runner.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/pylib/utils/report_results.py	View	1	4 chunks	+4 lines, -5 lines	0 comments	Download
M	build/android/test_runner.py	View		13 chunks	+2 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm https://codereview.chromium.org/22933005/diff/1/build/android/pylib/constants.py File build/android/pylib/constants.py (right): https://codereview.chromium.org/22933005/diff/1/build/android/pylib/constants.py#newcode86 build/android/pylib/constants.py:86: def GetBuildType(): As discussed, what you really care ...

7 years, 4 months ago (2013-08-14 21:45:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/22933005/7001

7 years, 4 months ago (2013-08-15 21:28:16 UTC) #4

bulach

7 years, 4 months ago (2013-08-16 09:06:57 UTC) #6

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/22933005/diff/7001/build/android/pylib...
File build/android/pylib/constants.py (right):

https://chromiumcodereview.appspot.com/22933005/diff/7001/build/android/pylib...
build/android/pylib/constants.py:88: return os.environ['CHROMIUM_BUILD_TYPE']
drive-by: at least downstream, buildbot passes BUILDTYPE, and I think that's
what other platforms use as well
http://dev.chromium.org/system/app/pages/search?scope=search-site&q=BUILDTYPE

maybe we should use that instead?

Expand Messages | Collapse Messages