Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3084)

Unified Diff: build/android/pylib/fake_dns.py

Issue 22933005: [android] Make build_type a singleton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix call to _LogToFile Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/fake_dns.py
diff --git a/build/android/pylib/fake_dns.py b/build/android/pylib/fake_dns.py
index b119d7600c928eceb1ec218b26a373fc62612aca..ed99d20fb3ec2ec4b7e8b0305715dc9bb01728b0 100644
--- a/build/android/pylib/fake_dns.py
+++ b/build/android/pylib/fake_dns.py
@@ -14,14 +14,12 @@ class FakeDns(object):
"""Wrapper class for the fake_dns tool."""
_FAKE_DNS_PATH = constants.TEST_EXECUTABLE_DIR + '/fake_dns'
- def __init__(self, adb, build_type):
+ def __init__(self, adb):
"""
Args:
adb: the AndroidCommands to use.
- build_type: 'Release' or 'Debug'.
"""
self._adb = adb
- self._build_type = build_type
self._fake_dns = None
self._original_dns = None
@@ -32,7 +30,7 @@ class FakeDns(object):
subprocess instance connected to the fake_dns process on the device.
"""
self._adb.PushIfNeeded(
- os.path.join(constants.DIR_SOURCE_ROOT, 'out', self._build_type,
+ os.path.join(constants.DIR_SOURCE_ROOT, 'out', constants.GetBuildType(),
'fake_dns'),
FakeDns._FAKE_DNS_PATH)
return subprocess.Popen(

Powered by Google App Engine
This is Rietveld 408576698