Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22922003: Remove notifications from Accessibility API (Closed)

Created:
7 years, 4 months ago by Cait (Slow)
Modified:
7 years, 4 months ago
CC:
Paweł Hajdan Jr., Avi (use Gerrit), chromium-reviews, extensions-reviews_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Remove notifications from Accessibility API TBR=darin@chromium.org BUG=268984 TEST= no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218171

Patch Set 1 #

Patch Set 2 : Remove second Event Router -- call Extension API directly #

Patch Set 3 : Clean up #

Total comments: 8

Patch Set 4 : Respond to comments #

Total comments: 8

Patch Set 5 : Comments 2 #

Total comments: 1

Patch Set 6 : Nits and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -265 lines) Patch
M chrome/browser/accessibility/accessibility_events.h View 1 2 3 4 5 1 chunk +18 lines, -6 lines 0 comments Download
M chrome/browser/accessibility/accessibility_events.cc View 1 2 3 4 5 2 chunks +30 lines, -6 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.h View 1 2 3 4 3 chunks +25 lines, -12 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.cc View 1 2 3 4 4 chunks +55 lines, -65 lines 0 comments Download
M chrome/browser/chrome_notification_types.h View 1 2 3 4 5 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 3 4 5 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views.h View 1 2 3 4 5 3 chunks +14 lines, -19 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views.cc View 1 2 3 4 5 15 chunks +44 lines, -90 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 1 2 3 4 10 chunks +18 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Cait (Slow)
Hi Dominic -- PTAL. This CL converts Accessibility-related Notifications to ui::Accessibility::Events, as we are working ...
7 years, 4 months ago (2013-08-14 19:29:19 UTC) #1
dmazzoni
Fantastic! https://codereview.chromium.org/22922003/diff/38001/chrome/browser/accessibility/accessibility_extension_api.cc File chrome/browser/accessibility/accessibility_extension_api.cc (left): https://codereview.chromium.org/22922003/diff/38001/chrome/browser/accessibility/accessibility_extension_api.cc#oldcode124 chrome/browser/accessibility/accessibility_extension_api.cc:124: void ExtensionAccessibilityEventRouter::OnWindowClosed( Was this never used? https://codereview.chromium.org/22922003/diff/38001/chrome/browser/accessibility/accessibility_extension_api.h File ...
7 years, 4 months ago (2013-08-14 19:36:36 UTC) #2
Cait (Slow)
https://codereview.chromium.org/22922003/diff/38001/chrome/browser/accessibility/accessibility_extension_api.cc File chrome/browser/accessibility/accessibility_extension_api.cc (left): https://codereview.chromium.org/22922003/diff/38001/chrome/browser/accessibility/accessibility_extension_api.cc#oldcode124 chrome/browser/accessibility/accessibility_extension_api.cc:124: void ExtensionAccessibilityEventRouter::OnWindowClosed( On 2013/08/14 19:36:37, Dominic Mazzoni wrote: > ...
7 years, 4 months ago (2013-08-14 20:53:36 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/22922003/diff/45001/chrome/browser/accessibility/accessibility_extension_api.cc File chrome/browser/accessibility/accessibility_extension_api.cc (right): https://codereview.chromium.org/22922003/diff/45001/chrome/browser/accessibility/accessibility_extension_api.cc#newcode65 chrome/browser/accessibility/accessibility_extension_api.cc:65: void ExtensionAccessibilityEventRouter::ClearControlEventCallback() { Nit: blank line before https://codereview.chromium.org/22922003/diff/45001/chrome/browser/accessibility/accessibility_extension_api.h ...
7 years, 4 months ago (2013-08-14 21:00:17 UTC) #4
Cait (Slow)
Peter: PTAL. Dominic has reviewed this change, but it is still in need of a ...
7 years, 4 months ago (2013-08-15 20:01:15 UTC) #5
Peter Kasting
LGTM https://codereview.chromium.org/22922003/diff/52001/chrome/browser/ui/views/accessibility/accessibility_event_router_views.h File chrome/browser/ui/views/accessibility/accessibility_event_router_views.h (right): https://codereview.chromium.org/22922003/diff/52001/chrome/browser/ui/views/accessibility/accessibility_event_router_views.h#newcode75 chrome/browser/ui/views/accessibility/accessibility_event_router_views.h:75: ui::AccessibilityTypes::Event type); Nit: Should this now be called ...
7 years, 4 months ago (2013-08-15 20:47:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/22922003/56001
7 years, 4 months ago (2013-08-16 16:34:37 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-17 13:52:22 UTC) #8
Message was sent while issue was closed. 
Change committed as 218171

Powered by Google App Engine
This is Rietveld 408576698