Issue 22920003: Use ARRAYSIZE_UNSAFE to find the number of painters in shader_bench.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22920003: Use ARRAYSIZE_UNSAFE to find the number of painters in shader_bench. (Closed)

Created:
7 years, 4 months ago by jbroman

Modified:
7 years, 4 months ago

Reviewers:
vrk (LEFT CHROMIUM), DaleCurtis, scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org, danakj

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Use ARRAYSIZE_UNSAFE to find the number of painters in shader_bench. Previously, a separate constant (kNumPainters) was used. This constant was incorrect (there were only two elements in the array). As described in http://www.viva64.com/en/b/0205/. BUG=271533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217124

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	media/tools/shader_bench/shader_bench.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

jbroman

I haven't been able to figure out how to run this tool to test that ...

7 years, 4 months ago (2013-08-12 19:49:25 UTC) #1

scherkus (not reviewing)

lgtm but it might be time to delete shader_bench, too :)

7 years, 4 months ago (2013-08-12 20:10:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/22920003/3001

7 years, 4 months ago (2013-08-12 20:15:11 UTC) #3

DaleCurtis

7 years, 4 months ago (2013-08-13 00:38:33 UTC) #5

Message was sent while issue was closed.

I fixed it here, but we could definitely delete it :) 

https://codereview.chromium.org/22979002/