Issue 22902007: Switch trace_inputs.py and isolate.py to subcommand.py.

Issue 22902007: Switch trace_inputs.py and isolate.py to subcommand.py. (Closed)

Created:
7 years, 4 months ago by M-A Ruel

Modified:
7 years, 4 months ago

Reviewers:
Vadim Sh.

CC:
chromium-reviews, csharp+cc_chromium.org, vadimsh+cc_chromium.org, maruel+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/swarm_client

Visibility:
Public.

More Reviews

Description

Switch trace_inputs.py and isolate.py to subcommand.py. Add subcommand.py and fix_encoding.py in third_party/depot_tools. This meant changing the CMD handlers a bit since in the case of subcommand.py, the OptionParser is shared across all commands. R=vadimsh@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=218301

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : cleaner imports #

Patch Set 4 : Now works #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1526 lines, -128 lines)			Patch
M	isolate.py	View	1 2 3	16 chunks	+35 lines, -32 lines	0 comments	Download
M	tests/isolate_smoke_test.py	View	1 2 3	1 chunk	+4 lines, -3 lines	2 comments	Download
M	tests/isolate_test.py	View	1	3 chunks	+3 lines, -12 lines	0 comments	Download
D	third_party/README.chromium	View	1 2	1 chunk	+0 lines, -11 lines	0 comments	Download
A +	third_party/README.swarming	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	third_party/colorama/LICENSE.txt	View	1 2 3	1 chunk	+33 lines, -0 lines	0 comments	Download
A	third_party/colorama/README.swarming	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
A	third_party/colorama/README.txt	View	1 2 3	1 chunk	+264 lines, -0 lines	0 comments	Download
A	third_party/colorama/__init__.py	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
A	third_party/colorama/ansi.py	View	1 2 3	1 chunk	+52 lines, -0 lines	0 comments	Download
A	third_party/colorama/ansitowin32.py	View	1 2 3	1 chunk	+189 lines, -0 lines	0 comments	Download
A	third_party/colorama/initialise.py	View	1 2 3	1 chunk	+55 lines, -0 lines	0 comments	Download
A	third_party/colorama/win32.py	View	1 2 3	1 chunk	+109 lines, -0 lines	0 comments	Download
A	third_party/colorama/winterm.py	View	1 2 3	1 chunk	+120 lines, -0 lines	0 comments	Download
A	third_party/depot_tools/README.swarming	View	1 2 3	1 chunk	+11 lines, -0 lines	0 comments	Download
A +	third_party/depot_tools/__init__.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	third_party/depot_tools/fix_encoding.py	View		1 chunk	+371 lines, -0 lines	0 comments	Download
A	third_party/depot_tools/subcommand.py	View	1 2 3	1 chunk	+251 lines, -0 lines	0 comments	Download
M	trace_inputs.py	View	1 2 3	7 chunks	+15 lines, -72 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

This CL can't be committed until https://codereview.chromium.org/23250002/ is committed so README.swarming can have the right ...

7 years, 4 months ago (2013-08-15 18:56:59 UTC) #1

iannucci

On 2013/08/15 18:56:59, M-A Ruel wrote: > This CL can't be committed until https://codereview.chromium.org/23250002/ is ...

7 years, 4 months ago (2013-08-15 20:51:20 UTC) #2

M-A Ruel

CL now ready for review. Robert, I had cc'ed you FYI but I meant to ...

7 years, 4 months ago (2013-08-17 19:02:43 UTC) #3

Vadim Sh.

lgtm with one question https://codereview.chromium.org/22902007/diff/9001/tests/isolate_smoke_test.py File tests/isolate_smoke_test.py (right): https://codereview.chromium.org/22902007/diff/9001/tests/isolate_smoke_test.py#newcode408 tests/isolate_smoke_test.py:408: regexp = '^ (?:\x1b\\[\\d\\dm)(\\w+)\s*(:?\x1b\\[\\d\\dm) .+' ...

7 years, 4 months ago (2013-08-19 17:54:02 UTC) #4

M-A Ruel

https://codereview.chromium.org/22902007/diff/9001/tests/isolate_smoke_test.py File tests/isolate_smoke_test.py (right): https://codereview.chromium.org/22902007/diff/9001/tests/isolate_smoke_test.py#newcode408 tests/isolate_smoke_test.py:408: regexp = '^ (?:\x1b\\[\\d\\dm)(\\w+)\s*(:?\x1b\\[\\d\\dm) .+' On 2013/08/19 17:54:02, Vadim ...

7 years, 4 months ago (2013-08-19 20:05:02 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/22902007/9001

7 years, 4 months ago (2013-08-19 20:15:27 UTC) #6

Message was sent while issue was closed.

Change committed as 218301

Expand Messages | Collapse Messages