Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Unified Diff: tests/isolate_smoke_test.py

Issue 22902007: Switch trace_inputs.py and isolate.py to subcommand.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/swarm_client
Patch Set: Now works Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « isolate.py ('k') | tests/isolate_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/isolate_smoke_test.py
diff --git a/tests/isolate_smoke_test.py b/tests/isolate_smoke_test.py
index c455c5b6f6d8e11e15307bded6f1eefd8dbd0603..7386229af1e8f8f27a14e90113d2e7e1c811dc38 100755
--- a/tests/isolate_smoke_test.py
+++ b/tests/isolate_smoke_test.py
@@ -403,10 +403,11 @@ class Isolate(unittest.TestCase):
cwd=ROOT_DIR)
out = p.communicate()[0].splitlines()
self.assertEqual(0, p.returncode)
- out = out[out.index('') + 1:]
+ out = out[out.index('Commands are:') + 1:]
out = out[:out.index('')]
- modes = [re.match(r'^ (\w+) .+', l) for l in out]
- modes = tuple(m.group(1) for m in modes if m)
+ regexp = '^ (?:\x1b\\[\\d\\dm)(\\w+)\s*(:?\x1b\\[\\d\\dm) .+'
Vadim Sh. 2013/08/19 17:54:02 err.... what is that? :) looks like write-only reg
M-A Ruel 2013/08/19 20:05:03 ANSI escape code. ESC[\d\dm http://en.wikipedia.or
+ modes = [re.match(regexp, l) for l in out]
+ modes = [m.group(1) for m in modes if m]
self.assertEqual(sorted(EXPECTED_MODES), sorted(modes))
def test_modes(self):
« no previous file with comments | « isolate.py ('k') | tests/isolate_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698