Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2289543005: Allow suspension prior to reaching kHaveFutureData. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow suspension prior to reaching kHaveFutureData. This change rolls in a few changes: - Removes DelegateState::PAUSED_BUT_NOT_IDLE state. - Removes all blocks against suspending prior to kHaveFutureData. - If suspended, triggers resume when prior to have kHaveFutureData if the didLoadingProgress() timer reports true. - Always notifies the delegate of DelegateState::GONE; this ensures the idle timer is always restarted if we didn't quite get enough data to reach kHaveFutureData. - Fixes pause timer to handle newly supported background video; which doesn't set a state of DelegateState::GONE BUG=612909, 643383 TEST=new and updated unittests. Committed: https://crrev.com/e7120dcf27938c9604ec03b3b574e1b4b3bf6c28 Cr-Commit-Position: refs/heads/master@{#416431}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Comments. #

Patch Set 3 : Rename to setPaused. #

Total comments: 4

Patch Set 4 : Fix comments. #

Patch Set 5 : Change approaches. #

Patch Set 6 : Rollup. #

Patch Set 7 : Fix pause timer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -65 lines) Patch
M content/renderer/media/renderer_webmediaplayer_delegate.cc View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 4 5 6 7 chunks +41 lines, -47 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 2 3 4 5 22 chunks +82 lines, -10 lines 0 comments Download

Messages

Total messages: 36 (9 generated)
DaleCurtis
4 years, 3 months ago (2016-08-29 23:42:52 UTC) #3
foolip
I think I need some more context on this, does this by itself fix the ...
4 years, 3 months ago (2016-08-30 15:30:07 UTC) #4
DaleCurtis
Prior to have future data, html media element does not forward play calls to wmpi. ...
4 years, 3 months ago (2016-08-30 17:25:12 UTC) #5
DaleCurtis
Vimeo gets in this state by appending an init segment but never any encoded data. ...
4 years, 3 months ago (2016-08-30 17:28:25 UTC) #6
sandersd (OOO until July 31)
https://codereview.chromium.org/2289543005/diff/1/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2289543005/diff/1/media/blink/webmediaplayer_impl.cc#newcode1655 media/blink/webmediaplayer_impl.cc:1655: // due to ordering of calls we may temporarily ...
4 years, 3 months ago (2016-08-30 18:40:18 UTC) #7
DaleCurtis
Addressed comments. I'm not really happy with setPlaybackState() as the name, but am not sure ...
4 years, 3 months ago (2016-08-30 21:56:04 UTC) #8
DaleCurtis
Latest patch set renames to setPaused() since it's a simpler extension of what's going on ...
4 years, 3 months ago (2016-08-30 22:30:44 UTC) #10
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/2289543005/diff/40001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2289543005/diff/40001/media/blink/webmediaplayer_impl.cc#newcode1668 media/blink/webmediaplayer_impl.cc:1668: // that period, we'll retain the most accurate ...
4 years, 3 months ago (2016-08-30 22:41:41 UTC) #11
DaleCurtis
https://codereview.chromium.org/2289543005/diff/40001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2289543005/diff/40001/media/blink/webmediaplayer_impl.cc#newcode1668 media/blink/webmediaplayer_impl.cc:1668: // that period, we'll retain the most accurate |paused_| ...
4 years, 3 months ago (2016-08-30 22:59:43 UTC) #12
foolip
On 2016/08/30 21:56:04, DaleCurtis wrote: > Addressed comments. I'm not really happy with setPlaybackState() as ...
4 years, 3 months ago (2016-08-31 20:45:07 UTC) #13
foolip
On 2016/08/31 20:45:07, foolip wrote: > On 2016/08/30 21:56:04, DaleCurtis wrote: > > Addressed comments. ...
4 years, 3 months ago (2016-08-31 20:48:56 UTC) #14
DaleCurtis
Prior to this change, WMPI has assumed it's unknown, but this prevents us from suspending ...
4 years, 3 months ago (2016-08-31 20:55:59 UTC) #15
foolip
Adding wolenetz@ as I'm about to say some things about MSE.
4 years, 3 months ago (2016-08-31 21:12:16 UTC) #17
foolip
On 2016/08/31 20:55:59, DaleCurtis wrote: > Prior to this change, WMPI has assumed it's unknown, ...
4 years, 3 months ago (2016-08-31 21:16:52 UTC) #18
DaleCurtis
On 2016/08/31 at 21:16:52, foolip wrote: > On 2016/08/31 20:55:59, DaleCurtis wrote: > > Prior ...
4 years, 3 months ago (2016-08-31 21:26:03 UTC) #19
foolip
On 2016/08/31 21:26:03, DaleCurtis wrote: > On 2016/08/31 at 21:16:52, foolip wrote: > > On ...
4 years, 3 months ago (2016-08-31 21:53:55 UTC) #20
DaleCurtis
On 2016/08/31 at 21:53:55, foolip wrote: > On 2016/08/31 21:26:03, DaleCurtis wrote: > > On ...
4 years, 3 months ago (2016-08-31 22:23:44 UTC) #21
sandersd (OOO until July 31)
> > Yes it's supposed to be completely transparent; though I believe sandersd@ > says ...
4 years, 3 months ago (2016-08-31 22:32:01 UTC) #22
sandersd (OOO until July 31)
On 2016/08/31 22:32:01, sandersd wrote: > > > Yes it's supposed to be completely transparent; ...
4 years, 3 months ago (2016-08-31 22:34:16 UTC) #23
DaleCurtis
Latest patch set completely changes the approach. Once foolip@ mentioned autoplay I went spelunking and ...
4 years, 3 months ago (2016-09-01 01:29:18 UTC) #24
foolip
On 2016/09/01 01:29:18, DaleCurtis wrote: > Latest patch set completely changes the approach. Once foolip@ ...
4 years, 3 months ago (2016-09-01 12:39:06 UTC) #25
sandersd (OOO until July 31)
This makes sense to me, only concern I have is fighting between many active players. ...
4 years, 3 months ago (2016-09-01 20:42:27 UTC) #26
DaleCurtis
PTAL. I needed to roll in a few of the other changes since they became ...
4 years, 3 months ago (2016-09-01 23:47:24 UTC) #28
wolenetz
Not sure I need to be on the R for this, though in general, ++documentation ...
4 years, 3 months ago (2016-09-02 23:07:04 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289543005/120001
4 years, 3 months ago (2016-09-02 23:22:32 UTC) #33
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-09-03 02:55:12 UTC) #34
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 02:57:06 UTC) #36
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/e7120dcf27938c9604ec03b3b574e1b4b3bf6c28
Cr-Commit-Position: refs/heads/master@{#416431}

Powered by Google App Engine
This is Rietveld 408576698