Issue 22893004: Add explicit keyword to constructors that take one argument

Issue 22893004: Add explicit keyword to constructors that take one argument (Closed)

Created:
7 years, 4 months ago by seokju.kwon

Modified:
7 years, 4 months ago

Reviewers:
levin, jochen (gone - plz use gerrit)

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, Timothy Loh, dstockwell, dglazkov+blink, apavlov+blink_chromium.org, darktears, Steve Block, jeez, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Add explicit keyword to constructors that take one argument BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156023

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	Source/core/css/CSSArrayFunctionValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSCanvasValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSFilterValue.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSFontSelector.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSGradientValue.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSImageGeneratorValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSImageSetValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSInitialValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSKeyframesRule.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSLineBoxContainValue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/animation/CSSAnimationData.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/animation/CSSAnimationDataList.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

I didn't find you on the CLA signers list, can you please sign one: http://dev.chromium.org/developers/contributing-code#TOC-Instructions-for-Reviewer:-Checking-in-the-patch-for-a-non-committer ...

7 years, 4 months ago (2013-08-13 09:48:03 UTC) #2

seokju.kwon

On 2013/08/13 09:48:03, jochen wrote: > I didn't find you on the CLA signers list, ...

7 years, 4 months ago (2013-08-13 10:03:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/seokju.kwon@gmail.com/22893004/1

7 years, 4 months ago (2013-08-13 14:06:26 UTC) #6

Message was sent while issue was closed.

Change committed as 156023

Expand Messages | Collapse Messages