Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: Source/core/css/CSSImageSetValue.h

Issue 22893004: Add explicit keyword to constructors that take one argument (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSImageGeneratorValue.h ('k') | Source/core/css/CSSInitialValue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 59
60 bool hasFailedOrCanceledSubresources() const; 60 bool hasFailedOrCanceledSubresources() const;
61 61
62 PassRefPtr<CSSImageSetValue> cloneForCSSOM() const; 62 PassRefPtr<CSSImageSetValue> cloneForCSSOM() const;
63 63
64 protected: 64 protected:
65 ImageWithScale bestImageForScaleFactor(); 65 ImageWithScale bestImageForScaleFactor();
66 66
67 private: 67 private:
68 CSSImageSetValue(); 68 CSSImageSetValue();
69 CSSImageSetValue(const CSSImageSetValue& cloneFrom); 69 explicit CSSImageSetValue(const CSSImageSetValue& cloneFrom);
70 70
71 void fillImageSet(); 71 void fillImageSet();
72 static inline bool compareByScaleFactor(ImageWithScale first, ImageWithScale second) { return first.scaleFactor < second.scaleFactor; } 72 static inline bool compareByScaleFactor(ImageWithScale first, ImageWithScale second) { return first.scaleFactor < second.scaleFactor; }
73 73
74 RefPtr<StyleImage> m_imageSet; 74 RefPtr<StyleImage> m_imageSet;
75 bool m_accessedBestFitImage; 75 bool m_accessedBestFitImage;
76 76
77 // This represents the scale factor that we used to find the best fit image. It does not necessarily 77 // This represents the scale factor that we used to find the best fit image. It does not necessarily
78 // correspond to the scale factor of the best fit image. 78 // correspond to the scale factor of the best fit image.
79 float m_scaleFactor; 79 float m_scaleFactor;
80 80
81 Vector<ImageWithScale> m_imagesInSet; 81 Vector<ImageWithScale> m_imagesInSet;
82 }; 82 };
83 83
84 } // namespace WebCore 84 } // namespace WebCore
85 85
86 #endif // CSSImageSetValue_h 86 #endif // CSSImageSetValue_h
OLDNEW
« no previous file with comments | « Source/core/css/CSSImageGeneratorValue.h ('k') | Source/core/css/CSSInitialValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698