Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 22888006: Use gfx::Screen to provide display information in WindowSizer (Closed)

Created:
7 years, 4 months ago by oshima
Modified:
7 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Use gfx::Screen to provide display information in WindowSizer I think this was necessary because gfx::Screen wasn't instance. BUG=272460 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219349

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -124 lines) Patch
M chrome/browser/ui/window_sizer/window_sizer.h View 1 3 chunks +7 lines, -21 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 6 chunks +9 lines, -33 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.h View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 1 2 3 chunks +87 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
7 years, 4 months ago (2013-08-23 08:34:23 UTC) #1
sky
Nice cleanup. LGTM
7 years, 4 months ago (2013-08-23 16:28:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/22888006/5001
7 years, 4 months ago (2013-08-23 16:58:02 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 4 months ago (2013-08-23 18:02:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/22888006/26001
7 years, 4 months ago (2013-08-23 19:13:27 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 21:51:52 UTC) #6
Message was sent while issue was closed.
Change committed as 219349

Powered by Google App Engine
This is Rietveld 408576698