[oilpan] Make the oilpan branch build on Mac.

[oilpan] Make the oilpan branch build on Mac.

R=haraken@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156628

[Mads Ager (chromium), 2013-08-23 11:08:25]

Changes needed to make it build:

1. remove explicit initialization of members since it leads to ambiguity errors
from compiler

2. remove malloc size part of consistency check for Vectors - it does not apply
when elements are in our heap

3. remove FAST_ALLOCATED a couple of places

4. rename verify and check methods since they conflict with macros defined by
the system

[haraken, 2013-08-23 11:12:49]

LGTM

https://codereview.chromium.org/22887044/diff/3001/Source/core/inspector/Insp...
File Source/core/inspector/InspectorStyleSheet.cpp (right):

https://codereview.chromium.org/22887044/diff/3001/Source/core/inspector/Insp...
Source/core/inspector/InspectorStyleSheet.cpp:111:
WebCore::Handle<CSSRuleSourceData> data = dataList.at(i);

Nit: I'm curious why this change is needed. It looks inconsistent that we have
'using WebCore::Member' and 'using WebCore::Result' but can't have 'using
WebCore::Handle'.

[Mads Ager (chromium), 2013-08-23 11:15:36]

Thanks Haraken.

https://codereview.chromium.org/22887044/diff/3001/Source/core/inspector/Insp...
File Source/core/inspector/InspectorStyleSheet.cpp (right):

https://codereview.chromium.org/22887044/diff/3001/Source/core/inspector/Insp...
Source/core/inspector/InspectorStyleSheet.cpp:111:
WebCore::Handle<CSSRuleSourceData> data = dataList.at(i);
On 2013/08/23 11:12:49, haraken wrote:
> 
> Nit: I'm curious why this change is needed. It looks inconsistent that we have
> 'using WebCore::Member' and 'using WebCore::Result' but can't have 'using
> WebCore::Handle'.

I agree. I'll add a FIXME(oilpan) about this. The issue is that in some Mac core
framework files that are used here there is another definition of Handle. The
compiler complaints that 'using WebCore::Handle' is conflicting with another
type that is already available. This is not a problem for the other ones.

[Mads Ager (chromium), 2013-08-23 11:17:34]

Committed patchset #3 manually as r156628 (presubmit successful).

[haraken, 2013-08-23 11:18:52]

https://codereview.chromium.org/22887044/diff/3001/Source/core/inspector/Insp...
File Source/core/inspector/InspectorStyleSheet.cpp (right):

https://codereview.chromium.org/22887044/diff/3001/Source/core/inspector/Insp...
Source/core/inspector/InspectorStyleSheet.cpp:111:
WebCore::Handle<CSSRuleSourceData> data = dataList.at(i);
> I agree. I'll add a FIXME(oilpan) about this. The issue is that in some Mac
core
> framework files that are used here there is another definition of Handle. The
> compiler complaints that 'using WebCore::Handle' is conflicting with another
> type that is already available. This is not a problem for the other ones.

Makes sense.

[Erik Corry, 2013-08-23 11:20:19]

https://codereview.chromium.org/22887044/diff/3001/Source/heap/Visitor.h
File Source/heap/Visitor.h (right):

https://codereview.chromium.org/22887044/diff/3001/Source/heap/Visitor.h#newc...
Source/heap/Visitor.h:200: static void checkTypeMarker(Visitor*, const void*) {
} \
These backslashes are kinda messy.