Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 22887030: Fix a crash on triggering bookmark menu directions by the arrow keys. (Closed)

Created:
7 years, 4 months ago by babu
Modified:
7 years, 3 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a crash on triggering bookmark menu directions by the arrow keys. Nothing to show in 'Other Bookmarks' when the folder is empty and not visible in the bookmarks bar. So, prevent moving selection to the hidden 'Other Bookmarks' folder to avoid a crash. BUG=275284 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221813

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
babu
7 years, 3 months ago (2013-09-05 18:55:36 UTC) #1
Elliot Glaysher
Evan, if you don't have any comments, I'm fine LGTMing this. I do want to ...
7 years, 3 months ago (2013-09-05 20:05:24 UTC) #2
Elliot Glaysher
On 2013/09/05 20:05:24, Elliot Glaysher wrote: > Evan, if you don't have any comments, I'm ...
7 years, 3 months ago (2013-09-06 19:06:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/22887030/1001
7 years, 3 months ago (2013-09-06 19:07:22 UTC) #4
Evan Stade
sorry. lgtm.
7 years, 3 months ago (2013-09-06 21:23:51 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 23:28:07 UTC) #6
Message was sent while issue was closed.
Change committed as 221813

Powered by Google App Engine
This is Rietveld 408576698