Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5156)

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

Issue 22887030: Fix a crash on triggering bookmark menu directions by the arrow keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
index b6082eb8b66b12549943428a9b1bf7841e279556..f4fae316eb202be1636404c9ac967258d970c870 100644
--- a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc
@@ -419,7 +419,9 @@ void BookmarkBarGtk::PopupForButtonNextTo(GtkWidget* button,
const int first_hidden = GetFirstHiddenBookmark(0, &folder_list);
if (first_hidden != -1)
folder_list.push_back(overflow_button_);
- folder_list.push_back(other_bookmarks_button_);
+
+ if (!model_->other_node()->empty())
+ folder_list.push_back(other_bookmarks_button_);
// Find the position of |button|.
int button_idx = -1;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698