Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22886002: Fix Matrix3F::SolveEigenproblem symmetry check. (Closed)

Created:
7 years, 4 months ago by jbroman
Modified:
7 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix Matrix3F::SolveEigenproblem symmetry check. As described in http://www.viva64.com/en/b/0205/. BUG=271533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/matrix3_f.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbroman
7 years, 4 months ago (2013-08-12 18:22:18 UTC) #1
danakj
NOTREACHED() makes this hard to write a test for :( LGTM as this fixes a ...
7 years, 4 months ago (2013-08-12 18:39:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/22886002/1
7 years, 4 months ago (2013-08-12 18:43:42 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 21:43:52 UTC) #4
Message was sent while issue was closed. 
Change committed as 217085

Powered by Google App Engine
This is Rietveld 408576698