ui/gfx/matrix3_f.cc - Issue 22886002: Fix Matrix3F::SolveEigenproblem symmetry check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/matrix3_f.cc

Issue 22886002: Fix Matrix3F::SolveEigenproblem symmetry check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/matrix3_f.cc

diff --git a/ui/gfx/matrix3_f.cc b/ui/gfx/matrix3_f.cc

index 501c5dda13ef83b43db9f7075ebed233e8a3a2f4..562fdb3a96470aeb50a516e72c08a2fd0e43f8f4 100644

--- a/ui/gfx/matrix3_f.cc

+++ b/ui/gfx/matrix3_f.cc

@@ -125,7 +125,7 @@ Vector3dF Matrix3F::SolveEigenproblem(Matrix3F* eigenvectors) const {

// The matrix must be symmetric.

const float epsilon = std::numeric_limits<float>::epsilon();

if (std::abs(data_[M01] - data_[M10]) > epsilon ||

- std::abs(data_[M02] - data_[M02]) > epsilon ||

+ std::abs(data_[M02] - data_[M20]) > epsilon ||

std::abs(data_[M12] - data_[M21]) > epsilon) {

NOTREACHED();

return Vector3dF();

« no previous file with comments | « no previous file | no next file » | no next file with comments »