chrome/browser/extensions/api/rtc_private/rtc_private_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/rtc_private/rtc_private_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('k') | chrome/browser/extensions/api/runtime/runtime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/rtc_private/rtc_private_api.cc

diff --git a/chrome/browser/extensions/api/rtc_private/rtc_private_api.cc b/chrome/browser/extensions/api/rtc_private/rtc_private_api.cc

index 642a30ac16bf89c24ea7359d8179aa948c60ef7b..ac1fe833f0fdcf200566064f3a410ee24d376867 100644

--- a/chrome/browser/extensions/api/rtc_private/rtc_private_api.cc

+++ b/chrome/browser/extensions/api/rtc_private/rtc_private_api.cc

@@ -67,7 +67,7 @@ void GetContactIntentData(const Contact& contact,

dict->Set(kPhoneIntentField, phone_list);

for (int i = 0; i < contact.phone_numbers_size(); i++) {

const Contact_PhoneNumber& phone_number = contact.phone_numbers(i);

- StringValue* value = Value::CreateStringValue(phone_number.number());

+ StringValue* value = new base::StringValue(phone_number.number());

if (phone_number.primary())

CHECK(phone_list->Insert(0, value));

else

@@ -78,7 +78,7 @@ void GetContactIntentData(const Contact& contact,

dict->Set(kEmailIntentField, email_list);

for (int i = 0; i < contact.email_addresses_size(); i++) {

const Contact_EmailAddress& email_address = contact.email_addresses(i);

- StringValue* value = Value::CreateStringValue(email_address.address());

+ StringValue* value = new base::StringValue(email_address.address());

if (email_address.primary())

CHECK(email_list->Insert(0, value));

else