Issue 22877041: Map typed data to ArrayBufferView on xhr send

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22877041: Map typed data to ArrayBufferView on xhr send (Closed)

Created:
7 years, 4 months ago by vsm

Modified:
7 years, 2 months ago

Reviewers:
siva, blois

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Map typed data to ArrayBufferView on xhr send BUG=12688 Might also fix 12648. R=asiva@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1453

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/bindings/dart/custom/DartXMLHttpRequestCustom.cpp	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/22877041/diff/1/Source/bindings/dart/custom/DartXMLHttpRequestCustom.cpp File Source/bindings/dart/custom/DartXMLHttpRequestCustom.cpp (right): https://chromiumcodereview.appspot.com/22877041/diff/1/Source/bindings/dart/custom/DartXMLHttpRequestCustom.cpp#newcode155 Source/bindings/dart/custom/DartXMLHttpRequestCustom.cpp:155: receiver->send(asArrayBufferView.get(), es); I think there is a bug ...

7 years, 4 months ago (2013-08-23 20:06:53 UTC) #2

vsm

7 years, 2 months ago (2013-10-18 20:35:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1453 (presubmit successful).

Expand Messages | Collapse Messages