Map typed data to ArrayBufferView on xhr send

Source/bindings/dart/custom/DartXMLHttpRequestCustom.cpp

 // Copyright 2011, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //    * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //    * Redistributions in binary form must reproduce the above
@@ skipping 131 matching lines @@
             Blob* asBlob = DartBlob::toNative(arg1, exception);
             if (exception)
                 goto fail;
             receiver->send(asBlob, es);
         } else if (DartDOMWrapper::instanceOf<DartFormData>(arg1)) {
             DOMFormData* asDOMFormData = DartFormData::toNative(arg1, exception);
             if (exception)
                 goto fail;
             receiver->send(asDOMFormData, es);
         } else if (DartUtilities::isTypedData(arg1)) {
-            RefPtr<ArrayBuffer> asArrayBuffer = DartUtilities::dartToArrayBuffer(arg1, exception);
+            RefPtr<ArrayBufferView> asArrayBufferView = DartUtilities::dartToArrayBufferView(arg1, exception);
             if (exception)
                 goto fail;
-            receiver->send(asArrayBuffer.get(), es);
+            receiver->send(asArrayBufferView.get(), es);

[siva, 2013/08/23 20:06:53]

I think there is a bug in both
DartUtilities::dartToArrayBuffer and
DartUtilities::dartToArrayBufferView

    // FIXME: we really shouldn't release the data until we are done with it.
    Dart_TypedDataReleaseData(array);
    byteLength = elementLength * elementSizeFromViewType(type);
    return externalize ? ArrayBuffer::create(data, byteLength) :
ArrayBuffer::createNoCopy(data, byteLength);


It releases the data pointer but stores it in the ArrayBuffer/ArrayBufferView
object in the case when 'externalize' is false which is the default case.

         } else {
             DartStringAdapter asString = DartUtilities::dartToString(arg1, exception);
             if (exception)
                 goto fail;
             receiver->send(asString, es);
         }
 
         if (es.hadException()) {
             exception = DartDOMWrapper::exceptionCodeToDartException(es);
             goto fail;
@@ skipping 107 matching lines @@
     }
 
 fail:
     Dart_ThrowException(exception);
     ASSERT_NOT_REACHED();
 }
 
 } // DartXMLHttpRequestInternal
 
 } // WebCore