Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 22875046: Don't serialize extension user script injection results unless the extension (Closed)

Created:
7 years, 4 months ago by not at google - send to devlin
Modified:
7 years, 3 months ago
Reviewers:
Matt Perry, Cris Neckar
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Don't serialize extension user script injection results unless the extension actually cares about the result. Times it might not care: if it's a content script injected declaratively, or if it doesn't give a result callback. BUG=269916 R=mpcomplete@chromium.org TBR=cdn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219908

Patch Set 1 #

Total comments: 1

Patch Set 2 : sensible v8::Context-ness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M chrome/browser/extensions/api/execute_code_function.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/script_executor.h View 2 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/extensions/script_executor.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.cc View 1 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
not at google - send to devlin
Same bug, but this one doesn't break incompatibility in any way, but also doesn't cover ...
7 years, 4 months ago (2013-08-23 00:25:40 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/22875046/diff/1/chrome/renderer/extensions/chrome_v8_context_set.h File chrome/renderer/extensions/chrome_v8_context_set.h (right): https://codereview.chromium.org/22875046/diff/1/chrome/renderer/extensions/chrome_v8_context_set.h#newcode71 chrome/renderer/extensions/chrome_v8_context_set.h:71: ChromeV8Context* GetByWebFrame(WebKit::WebFrame* web_frame) const; Ok this method doesn't make ...
7 years, 4 months ago (2013-08-23 01:19:13 UTC) #2
Matt Perry
lgtm
7 years, 4 months ago (2013-08-23 18:54:09 UTC) #3
not at google - send to devlin
+cdn for extension messages
7 years, 4 months ago (2013-08-23 20:18:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/22875046/20001
7 years, 3 months ago (2013-08-27 15:36:10 UTC) #5
Cris Neckar
IPC changes lgtm
7 years, 3 months ago (2013-08-27 17:20:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/22875046/20001
7 years, 3 months ago (2013-08-28 00:40:43 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-08-28 04:08:43 UTC) #8
Message was sent while issue was closed.
Change committed as 219908

Powered by Google App Engine
This is Rietveld 408576698