Issue 22875036: Android perf test runner: fixes exit_code.

Issue 22875036: Android perf test runner: fixes exit_code. (Closed)

Created:
7 years, 4 months ago by bulach

Modified:
7 years, 4 months ago

Reviewers:
frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android perf test runner: fixes exit_code. Sometimes the exit_code is None, and that should be treated as an error condition. BUG=277450 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219300

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/android/pylib/perf/test_runner.py	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm https://codereview.chromium.org/22875036/diff/1/build/android/pylib/perf/test_runner.py File build/android/pylib/perf/test_runner.py (right): https://codereview.chromium.org/22875036/diff/1/build/android/pylib/perf/test_runner.py#newcode119 build/android/pylib/perf/test_runner.py:119: exit_code = -1 Ah, this might a bug ...

7 years, 4 months ago (2013-08-22 17:43:06 UTC) #2

bulach

https://codereview.chromium.org/22875036/diff/1/build/android/pylib/perf/test_runner.py File build/android/pylib/perf/test_runner.py (right): https://codereview.chromium.org/22875036/diff/1/build/android/pylib/perf/test_runner.py#newcode119 build/android/pylib/perf/test_runner.py:119: exit_code = -1 On 2013/08/22 17:43:06, frankf wrote: > ...

7 years, 4 months ago (2013-08-23 09:01:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/22875036/1

7 years, 4 months ago (2013-08-23 09:03:03 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=71326

7 years, 4 months ago (2013-08-23 12:40:54 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/22875036/1

7 years, 4 months ago (2013-08-23 14:53:06 UTC) #6

Message was sent while issue was closed.

Change committed as 219300

Expand Messages | Collapse Messages