Android perf test runner: fixes exit_code.

build/android/pylib/perf/test_runner.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs a perf test on a single device.
 
 Our buildbot infrastructure requires each slave to run steps serially.
 This is sub-optimal for android, where these steps can run independently on
 multiple connected devices.
 
@@ skipping 97 matching lines @@
     """
     cmd = ('%s --device %s --keep_test_server_ports' %
            (self._tests[test_name], self.device))
     logging.info('%s : %s', test_name, cmd)
     start_time = datetime.datetime.now()
     output, exit_code = pexpect.run(
         cmd, cwd=os.path.abspath(constants.DIR_SOURCE_ROOT),
         withexitstatus=True, logfile=sys.stdout, timeout=1800,
         env=os.environ)
     end_time = datetime.datetime.now()
+    if exit_code is None:
+      exit_code = -1

[frankf, 2013/08/22 17:43:06]

Ah, this might a bug in pexpect I was talking about. 

[bulach, 2013/08/23 09:01:16]

:)

I don't quite get why / which test happened yet, so hopefully with these patches
we'll have more info...

     logging.info('%s : exit_code=%d in %d secs at %s',
                  test_name, exit_code, (end_time - start_time).seconds,
                  self.device)
     result_type = base_test_result.ResultType.FAIL
     if exit_code == 0:
       result_type = base_test_result.ResultType.PASS
     if test_name in self._flaky_tests:
       exit_code = 0
       result_type = base_test_result.ResultType.PASS
 
@@ skipping 18 matching lines @@
     Returns:
       A tuple of (TestRunResults, retry).
     """
     output, result_type = self._LaunchPerfTest(test_name)
     results = base_test_result.TestRunResults()
     results.AddResult(base_test_result.BaseTestResult(test_name, result_type))
     retry = None
     if not results.DidRunPass():
       retry = test_name
     return results, retry