Content-sized resolution should only happen on content-sized tracks

Content-sized resolution should only happen on content-sized tracks

The current code would always try to run the content sized
algorithm regardless of whether this was needed. On top of
it, it would iterate over ALL grid items, even if only a
small set of the tracks were content-sized.

This change stores of which tracks are content-sized and
use the internal grid to only iterate over these tracks.

On a Z620, this speeds up
PerformanceTests/Layout/fixed-grid-lots-of-data.html from
about 550 runs / sec to 830 runs / sec.

BUG=273238
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156168

[ojan, 2013-08-14 23:48:36]

lgtm

https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/G...
File Source/core/rendering/style/GridLength.h (right):

https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/G...
Source/core/rendering/style/GridLength.h:75: bool isContentSized() const {
return m_type == LengthType && (m_length.isAuto() || m_length.isMinContent() ||
m_length.isMaxContent()); }
What about fitcontent?

[Julien - ping for review, 2013-08-15 00:11:16]

https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/G...
File Source/core/rendering/style/GridLength.h (right):

https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/G...
Source/core/rendering/style/GridLength.h:75: bool isContentSized() const {
return m_type == LengthType && (m_length.isAuto() || m_length.isMinContent() ||
m_length.isMaxContent()); }
On 2013/08/14 23:48:36, ojan wrote:
> What about fitcontent?

It would be an issue if it applied to <track-breadth> (we test that it doesn't
apply in grid-columns-rows-get-set.html). Per CSS sizing, it only applies to
width / max-width / min-width (same for height) but we bundle it into Length
which is confusing.

[ojan, 2013-08-15 02:43:23]

lgtm

https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/G...
File Source/core/rendering/style/GridLength.h (right):

https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/G...
Source/core/rendering/style/GridLength.h:75: bool isContentSized() const {
return m_type == LengthType && (m_length.isAuto() || m_length.isMinContent() ||
m_length.isMaxContent()); }
On 2013/08/15 00:11:16, Julien Chaffraix wrote:
> On 2013/08/14 23:48:36, ojan wrote:
> > What about fitcontent?
> 
> It would be an issue if it applied to <track-breadth> (we test that it doesn't
> apply in grid-columns-rows-get-set.html). Per CSS sizing, it only applies to
> width / max-width / min-width (same for height) but we bundle it into Length
> which is confusing.

Sorry if I'm rehashing things...is there a good reason for it not to apply to
track breadths?

[Julien - ping for review, 2013-08-15 18:24:06]

https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/G...
File Source/core/rendering/style/GridLength.h (right):

https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/G...
Source/core/rendering/style/GridLength.h:75: bool isContentSized() const {
return m_type == LengthType && (m_length.isAuto() || m_length.isMinContent() ||
m_length.isMaxContent()); }
On 2013/08/15 02:43:23, ojan wrote:
> On 2013/08/15 00:11:16, Julien Chaffraix wrote:
> > On 2013/08/14 23:48:36, ojan wrote:
> > > What about fitcontent?
> > 
> > It would be an issue if it applied to <track-breadth> (we test that it
doesn't
> > apply in grid-columns-rows-get-set.html). Per CSS sizing, it only applies to
> > width / max-width / min-width (same for height) but we bundle it into Length
> > which is confusing.
> 
> Sorry if I'm rehashing things...is there a good reason for it not to apply to
> track breadths?

A reason is that it would be redundant with 'auto' (aka minmax(mincontent,
max-content)) as they both accomplish the same behavior.

[commit-bot: I haz the power, 2013-08-15 19:29:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22867006/1

[commit-bot: I haz the power, 2013-08-15 20:45:12]

Change committed as 156168