Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 22867006: Content-sized resolution should only happen on content-sized tracks (Closed)

Created:
6 years, 4 months ago by Julien - ping for review
Modified:
6 years, 4 months ago
Reviewers:
ojan
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, ojan, esprehn, eseidel
Visibility:
Public.

Description

Content-sized resolution should only happen on content-sized tracks The current code would always try to run the content sized algorithm regardless of whether this was needed. On top of it, it would iterate over ALL grid items, even if only a small set of the tracks were content-sized. This change stores of which tracks are content-sized and use the internal grid to only iterate over these tracks. On a Z620, this speeds up PerformanceTests/Layout/fixed-grid-lots-of-data.html from about 550 runs / sec to 830 runs / sec. BUG=273238 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156168

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M Source/core/rendering/RenderGrid.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 4 chunks +27 lines, -16 lines 0 comments Download
M Source/core/rendering/style/GridLength.h View 1 chunk +2 lines, -0 lines 4 comments Download
M Source/core/rendering/style/GridTrackSize.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Julien - ping for review
6 years, 4 months ago (2013-08-14 23:17:30 UTC) #1
ojan
lgtm https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/GridLength.h File Source/core/rendering/style/GridLength.h (right): https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/GridLength.h#newcode75 Source/core/rendering/style/GridLength.h:75: bool isContentSized() const { return m_type == LengthType ...
6 years, 4 months ago (2013-08-14 23:48:36 UTC) #2
Julien - ping for review
https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/GridLength.h File Source/core/rendering/style/GridLength.h (right): https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/GridLength.h#newcode75 Source/core/rendering/style/GridLength.h:75: bool isContentSized() const { return m_type == LengthType && ...
6 years, 4 months ago (2013-08-15 00:11:16 UTC) #3
ojan
lgtm https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/GridLength.h File Source/core/rendering/style/GridLength.h (right): https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/GridLength.h#newcode75 Source/core/rendering/style/GridLength.h:75: bool isContentSized() const { return m_type == LengthType ...
6 years, 4 months ago (2013-08-15 02:43:23 UTC) #4
Julien - ping for review
https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/GridLength.h File Source/core/rendering/style/GridLength.h (right): https://codereview.chromium.org/22867006/diff/1/Source/core/rendering/style/GridLength.h#newcode75 Source/core/rendering/style/GridLength.h:75: bool isContentSized() const { return m_type == LengthType && ...
6 years, 4 months ago (2013-08-15 18:24:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/22867006/1
6 years, 4 months ago (2013-08-15 19:29:25 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2013-08-15 20:45:12 UTC) #7
Message was sent while issue was closed.
Change committed as 156168

Powered by Google App Engine
This is Rietveld 408576698