Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: Source/core/rendering/style/GridLength.h

Issue 22867006: Content-sized resolution should only happen on content-sized tracks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderGrid.cpp ('k') | Source/core/rendering/style/GridTrackSize.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 { 65 {
66 m_type = FlexType; 66 m_type = FlexType;
67 m_flex = flex; 67 m_flex = flex;
68 } 68 }
69 69
70 bool operator==(const GridLength& o) const 70 bool operator==(const GridLength& o) const
71 { 71 {
72 return m_length == o.m_length; 72 return m_length == o.m_length;
73 } 73 }
74 74
75 bool isContentSized() const { return m_type == LengthType && (m_length.isAut o() || m_length.isMinContent() || m_length.isMaxContent()); }
ojan 2013/08/14 23:48:36 What about fitcontent?
Julien - ping for review 2013/08/15 00:11:16 It would be an issue if it applied to <track-bread
ojan 2013/08/15 02:43:23 Sorry if I'm rehashing things...is there a good re
Julien - ping for review 2013/08/15 18:24:07 A reason is that it would be redundant with 'auto'
76
75 private: 77 private:
76 // Ideally we would put the 2 following fields in a union, but Length has a constructor, 78 // Ideally we would put the 2 following fields in a union, but Length has a constructor,
77 // a destructor and a copy assignment which isn't allowed. 79 // a destructor and a copy assignment which isn't allowed.
78 Length m_length; 80 Length m_length;
79 double m_flex; 81 double m_flex;
80 enum GridLengthType { 82 enum GridLengthType {
81 LengthType, 83 LengthType,
82 FlexType 84 FlexType
83 }; 85 };
84 GridLengthType m_type; 86 GridLengthType m_type;
85 }; 87 };
86 88
87 } // namespace WebCore 89 } // namespace WebCore
88 90
89 #endif // GridLength_h 91 #endif // GridLength_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderGrid.cpp ('k') | Source/core/rendering/style/GridTrackSize.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698