Issue 22865023: Move gpu conic calculations to GrPathUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22865023: Move gpu conic calculations to GrPathUtils (Closed)

Created:
7 years, 4 months ago by egdaniel

Modified:
7 years, 4 months ago

Reviewers:
jvanverth1, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Move gpu conic calculations to GrPathUtils BUG= Committed: http://code.google.com/p/skia/source/detail?r=10832

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -52 lines)			Patch
M	src/gpu/GrAAHairLinePathRenderer.cpp	View		1 chunk	+9 lines, -52 lines	0 comments	Download
M	src/gpu/GrPathUtils.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/gpu/GrPathUtils.cpp	View		1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm w/ spelling nit. https://codereview.chromium.org/22865023/diff/1/src/gpu/GrPathUtils.h File src/gpu/GrPathUtils.h (right): https://codereview.chromium.org/22865023/diff/1/src/gpu/GrPathUtils.h#newcode101 src/gpu/GrPathUtils.h:101: // three linear functionals (K,L,M) ...

7 years, 4 months ago (2013-08-20 16:07:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/22865023/6001

7 years, 4 months ago (2013-08-20 17:16:15 UTC) #3

Message was sent while issue was closed.

Change committed as 10832

Expand Messages | Collapse Messages

Issue 22865023: Move gpu conic calculations to GrPathUtils (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages