Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 22865021: REGRESSION: SVG <a> elmenet ignores tabsToLinks setting (Closed)

Created:
7 years, 4 months ago by tkent
Modified:
7 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, pdr, f(malita), dglazkov+blink, eae+blinkwatch, Stephen Chennney
Visibility:
Public.

Description

REGRESSION: SVG <a> elmenet ignores tabsToLinks setting The regression caused by Blink r155290, which removed an argumetn of isKeyboardFocusable. We forgot to remove the argument for SVGAElement::isKeyboardFocusable. BUG=276105 TEST=automated Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156373

Patch Set 1 #

Patch Set 2 : Move the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
A LayoutTests/svg/custom/a-focus-by-tab.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/a-focus-by-tab-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
Probably the test is in a wrong place.
7 years, 4 months ago (2013-08-20 06:00:43 UTC) #1
pdr.
On 2013/08/20 06:00:43, tkent wrote: > Probably the test is in a wrong place. LGTM, ...
7 years, 4 months ago (2013-08-20 06:26:41 UTC) #2
tkent
> LGTM, mind putting the test in LayoutTests/svg/custom or LayoutTests/svg/text > though? Thanks. I'll move ...
7 years, 4 months ago (2013-08-20 06:49:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/22865021/3009
7 years, 4 months ago (2013-08-20 07:42:59 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-20 07:51:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/22865021/3009
7 years, 4 months ago (2013-08-20 07:52:37 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-20 08:04:13 UTC) #7
Message was sent while issue was closed.
Change committed as 156373

Powered by Google App Engine
This is Rietveld 408576698