Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: Source/core/svg/SVGAElement.cpp

Issue 22865021: REGRESSION: SVG <a> elmenet ignores tabsToLinks setting (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Move the test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 bool SVGAElement::isURLAttribute(const Attribute& attribute) const 210 bool SVGAElement::isURLAttribute(const Attribute& attribute) const
211 { 211 {
212 return attribute.name().localName() == hrefAttr || SVGGraphicsElement::isURL Attribute(attribute); 212 return attribute.name().localName() == hrefAttr || SVGGraphicsElement::isURL Attribute(attribute);
213 } 213 }
214 214
215 bool SVGAElement::isMouseFocusable() const 215 bool SVGAElement::isMouseFocusable() const
216 { 216 {
217 return false; 217 return false;
218 } 218 }
219 219
220 bool SVGAElement::isKeyboardFocusable(KeyboardEvent*) const 220 bool SVGAElement::isKeyboardFocusable() const
221 { 221 {
222 if (!isFocusable()) 222 if (!isFocusable())
223 return false; 223 return false;
224 224
225 Page* page = document()->page(); 225 Page* page = document()->page();
226 if (!page) 226 if (!page)
227 return false; 227 return false;
228 228
229 return page->chrome().client()->tabsToLinks(); 229 return page->chrome().client()->tabsToLinks();
230 } 230 }
231 231
232 bool SVGAElement::childShouldCreateRenderer(const NodeRenderingContext& childCon text) const 232 bool SVGAElement::childShouldCreateRenderer(const NodeRenderingContext& childCon text) const
233 { 233 {
234 // http://www.w3.org/2003/01/REC-SVG11-20030114-errata#linking-text-environm ent 234 // http://www.w3.org/2003/01/REC-SVG11-20030114-errata#linking-text-environm ent
235 // The 'a' element may contain any element that its parent may contain, exce pt itself. 235 // The 'a' element may contain any element that its parent may contain, exce pt itself.
236 if (childContext.node()->hasTagName(SVGNames::aTag)) 236 if (childContext.node()->hasTagName(SVGNames::aTag))
237 return false; 237 return false;
238 if (parentNode() && parentNode()->isSVGElement()) 238 if (parentNode() && parentNode()->isSVGElement())
239 return parentNode()->childShouldCreateRenderer(childContext); 239 return parentNode()->childShouldCreateRenderer(childContext);
240 240
241 return SVGElement::childShouldCreateRenderer(childContext); 241 return SVGElement::childShouldCreateRenderer(childContext);
242 } 242 }
243 243
244 } // namespace WebCore 244 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698