Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 22841004: Negative check for a HANDLE is invalid. (Closed)

Created:
7 years, 4 months ago by jbroman
Modified:
7 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Negative check for a HANDLE is invalid. kInvalidPlatformFileValue is the invalid platform file handle. BUG=271533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/platform_file_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbroman
HANDLE is a pointer. It won't be negative. The correct check, as used in other ...
7 years, 4 months ago (2013-08-12 19:09:37 UTC) #1
darin (slow to review)
LGTM
7 years, 4 months ago (2013-08-12 19:32:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/22841004/1
7 years, 4 months ago (2013-08-12 19:50:58 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 22:34:09 UTC) #4
Message was sent while issue was closed.
Change committed as 217103

Powered by Google App Engine
This is Rietveld 408576698