base/platform_file_win.cc - Issue 22841004: Negative check for a HANDLE is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/platform_file_win.cc

Issue 22841004: Negative check for a HANDLE is invalid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/platform_file_win.cc

diff --git a/base/platform_file_win.cc b/base/platform_file_win.cc

index 977a819fcfa70eef7cde008a4909324071700a26..c5b49fa7e88ef1fea45c049e12822837b5c44f7e 100644

--- a/base/platform_file_win.cc

+++ b/base/platform_file_win.cc

@@ -121,7 +121,7 @@ int64 SeekPlatformFile(PlatformFile file,

PlatformFileWhence whence,

int64 offset) {

base::ThreadRestrictions::AssertIOAllowed();

- if (file < 0 || offset < 0)

+ if (file == kInvalidPlatformFileValue || offset < 0)

return -1;

LARGE_INTEGER distance, res;

« no previous file with comments | « no previous file | no next file » | no next file with comments »