Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2283863003: Converted Observatory object-pool-view element (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 41f0dc2c73f6fcd726b93fda79a061ec4ca3d317..2d692ae25604978db43a7181031b03d962338ecb 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -15,6 +15,8 @@ InboundReferencesRepository _inboundReferencesRepository
InstanceRepository _instanceRepository = new InstanceRepository();
IsolateSampleProfileRepository _isolateSampleProfileRepository
= new IsolateSampleProfileRepository();
+ObjectPoolRepository _objectPoolRepository
+ = new ObjectPoolRepository();
ObjectStoreRepository _objectstoreRepository
= new ObjectStoreRepository();
PersistentHandlesRepository _persistentHandlesRepository
@@ -185,7 +187,9 @@ class InspectPage extends MatchingPage {
assert(element != null);
}
- void _visitObject(obj) {
+ Future _visitObject(obj) async {
+ container.children = [];
+ await obj.reload();
if (obj is Context) {
container.children = [
new ContextViewElement(app.vm, obj.isolate, obj, app.events,
@@ -214,6 +218,18 @@ class InspectPage extends MatchingPage {
_instanceRepository,
queue: app.queue)
];
+ } else if (obj is ObjectPool) {
+ container.children = [
+ new ObjectPoolViewElement(app.vm, obj.isolate, obj, app.events,
+ app.notifications,
+ _objectPoolRepository,
+ _retainedSizeRepository,
+ _reachableSizeRepository,
+ _inboundReferencesRepository,
+ _retainingPathRepository,
+ _instanceRepository,
+ queue: app.queue)
+ ];
} else {
ServiceObjectViewElement serviceElement =new Element.tag('service-view');
serviceElement.object = obj;

Powered by Google App Engine
This is Rietveld 408576698