Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2283863003: Converted Observatory object-pool-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -89 lines) Patch
M runtime/observatory/lib/elements.dart View 1 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 3 chunks +17 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.dart View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.dart View 1 1 chunk +162 lines, -9 lines 0 comments Download
D runtime/observatory/lib/src/elements/objectpool_view.html View 1 chunk +0 lines, -49 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/objectpool.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/objectpool.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/objectpool.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 chunks +40 lines, -3 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 3 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/objectpool.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/objectpool.dart View 1 chunk +22 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/objectpool_view/element_test.dart View 2 chunks +14 lines, -14 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/objectpool_view/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-26 22:11:00 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/2283863003/diff/1/runtime/observatory/lib/src/elements/css/shared.css File runtime/observatory/lib/src/elements/css/shared.css (right): https://chromiumcodereview.appspot.com/2283863003/diff/1/runtime/observatory/lib/src/elements/css/shared.css#newcode1248 runtime/observatory/lib/src/elements/css/shared.css:1248: object-pool-view .exadecimal { hexadecimal https://chromiumcodereview.appspot.com/2283863003/diff/1/runtime/observatory/lib/src/elements/objectpool_view.dart File runtime/observatory/lib/src/elements/objectpool_view.dart (right): ...
4 years, 3 months ago (2016-08-29 17:55:15 UTC) #3
cbernaschina
https://codereview.chromium.org/2283863003/diff/1/runtime/observatory/lib/src/elements/css/shared.css File runtime/observatory/lib/src/elements/css/shared.css (right): https://codereview.chromium.org/2283863003/diff/1/runtime/observatory/lib/src/elements/css/shared.css#newcode1248 runtime/observatory/lib/src/elements/css/shared.css:1248: object-pool-view .exadecimal { On 2016/08/29 17:55:15, rmacnak wrote: > ...
4 years, 3 months ago (2016-08-29 18:13:57 UTC) #4
cbernaschina
4 years, 3 months ago (2016-08-29 18:14:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a326a56eb10942d46b4d1a4c0cc637655c69579d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698