Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 22837004: Change default ReportErrorFileAndLine to use filename:lineno format. (Closed)

Created:
7 years, 4 months ago by danakj
Modified:
7 years, 4 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, piman
Visibility:
Public.

Description

Change default ReportErrorFileAndLine to use filename:lineno format. Currently the output is: Found line ending with white spaces in: cc/trees/layer_tree_host_impl_unittest.cc, line 379 This format is extremely annoying because you must combine the file and line number together by hand. A more standard format for expressing a position in a file is filename:lineno. This changes the format to match: Found line ending with white spaces in: cc/trees/layer_tree_host_impl_unittest.cc:379 R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=217405

Patch Set 1 : ReportErrorFileAndLine: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M presubmit_canned_checks.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
7 years, 4 months ago (2013-08-14 00:24:48 UTC) #1
M-A Ruel
lgtm
7 years, 4 months ago (2013-08-14 00:25:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/22837004/5001
7 years, 4 months ago (2013-08-14 00:25:44 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-14 00:27:26 UTC) #4
Message was sent while issue was closed.
Change committed as 217405

Powered by Google App Engine
This is Rietveld 408576698