presubmit_canned_checks.py - Issue 22837004: Change default ReportErrorFileAndLine to use filename:lineno format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 22837004: Change default ReportErrorFileAndLine to use filename:lineno format. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: ReportErrorFileAndLine: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 68b981908938e48685012fb5644c72b5b36d35e8..aecdd83fa50e9621f36557ba6583afd415ad0ce4 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -228,7 +228,7 @@ def CheckChangeHasNoCrAndHasOnlyOneEol(input_api, output_api,

def _ReportErrorFileAndLine(filename, line_num, dummy_line):

"""Default error formatter for _FindNewViolationsOfRule."""

- return '%s, line %s' % (filename, line_num)

+ return '%s:%s' % (filename, line_num)

def _FindNewViolationsOfRule(callable_rule, input_api, source_file_filter=None,

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »